Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set new required build fields in the ReadTheDocs config file #1803

Merged
merged 3 commits into from Oct 17, 2023

Conversation

micahellison
Copy link
Member

@micahellison micahellison commented Sep 28, 2023

ReadTheDocs is warning us that we need to add build.os to our configuration file before October 16. This PR makes the change by selecting the latest available Ubuntu version.

Edit: Turns out they need build.tools.python as well, so I'm setting that here too. I think setting to "3" for the latest version of Python 3 is acceptable for documentation builds, rather than pinning to a specific version, but I'm open to changing it.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

@micahellison micahellison added the build Issues related to the build pipeline label Sep 28, 2023
@micahellison micahellison changed the title Set build.os in the ReadTheDocs config file Set new required build fields in the ReadTheDocs config file Sep 28, 2023
@micahellison micahellison marked this pull request as ready for review September 28, 2023 21:21
@micahellison micahellison merged commit 09a96e6 into jrnl-org:develop Oct 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant