Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Poetry for dependency management and deployments #612

Merged
merged 2 commits into from Aug 16, 2019
Merged

Conversation

maebert
Copy link
Contributor

@maebert maebert commented Jul 8, 2019

Since jrnl was first written in 2012, a lot has happened in the wonderful world of dependency management and python deployments. This PR moves the deployment process to Poetry, which has the following advantages over pip or pipenv

  • Requirements can be locked (similar Ruby gems or Yarn), creating less dependency conflicts for users and developers
  • Poetry handles virtual environments, no need to create and maintain one yourself
  • It's super easy to publish from Travis straight to PyPi (set to deploy from master on tagged commits)

With poetry, the new development workflow is

# 1. Set up environment
git clone ...
cd jrnl
poetry install

# 2. Add new dependencies
poetry add my-dependency

# 3. Run tests (or any other command that requires the installed dependencies)
poetry run behave

I'll update the documentation for this after #611 is merged.

Also fixes #610.

@maebert maebert requested a review from wren July 8, 2019 04:07
@maebert maebert force-pushed the manu--poetry branch 2 times, most recently from e43b8ea to bcea98d Compare July 8, 2019 23:06
@wren wren added this to the v2.1 - Pipeline Streamline milestone Jul 16, 2019
@wren
Copy link
Member

wren commented Jul 16, 2019

This is a good update, but it changes a few dependencies. I think that introduces risk to v2.0 since we already have people testing, and I don't want to lose that momentum. I'd love to get this merged in first thing for v2.1, though.

@wren wren added the enhancement New feature or request label Jul 16, 2019
@maebert
Copy link
Contributor Author

maebert commented Jul 16, 2019

Yup, agree, let's get 2.0 in first and then rebase this against master.

@maebert maebert mentioned this pull request Aug 2, 2019
@wren wren added the 📌 This can't go stale label Aug 6, 2019
@wren wren changed the base branch from v2.0-rc2 to master August 16, 2019 00:27
@wren wren changed the base branch from master to v2.1 August 16, 2019 00:38
@wren wren merged commit 4c516a8 into v2.1 Aug 16, 2019
@wren wren deleted the manu--poetry branch August 16, 2019 00:50
@wren wren added build Issues related to the build pipeline and removed enhancement New feature or request labels Jan 10, 2020
@lock
Copy link

lock bot commented May 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Issues related to the build pipeline 🔒 Outdated 📌 This can't go stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants