Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to hashmark Markdown headers on export (Mk II) #639

Merged
merged 3 commits into from Aug 16, 2019

Conversation

MinchinWeb
Copy link
Contributor

Re-create #506, re-based to the current 2.0-rc3 master branch.

Closes #487, Closes #506

Switches from ATX to 'Hashmark' style Markdown headers for single file markdown exports.

(I tried to force-push to the branch to update #506, but just managed to close PR. Oops!)

@MinchinWeb MinchinWeb added the enhancement New feature or request label Aug 2, 2019
@MinchinWeb
Copy link
Contributor Author

@wren #506, now with passing tests!

@MinchinWeb MinchinWeb mentioned this pull request Aug 2, 2019
@wren wren added this to the v2.0.1 milestone Aug 3, 2019
@wren
Copy link
Member

wren commented Aug 3, 2019

@MinchinWeb Nice! Thank you!

@wren wren changed the base branch from master to v2.0.1 August 16, 2019 01:44
@wren wren merged commit 6d3c35b into jrnl-org:v2.0.1 Aug 16, 2019
@MinchinWeb MinchinWeb deleted the export-md-headers branch August 16, 2019 15:16
@MinchinWeb
Copy link
Contributor Author

@wren How does the v2.0.1 branch relate to the master branch?

@wren
Copy link
Member

wren commented Aug 20, 2019

@MinchinWeb The v* branches are holding branches for code that is done ahead of time for a given milestone. The master branch is the current version in development.

When the master branch reaches a version, it'll be tagged, released, and the next version's branch will be merged into master so we can begin testing the build for the next version as soon as possible.

@lock
Copy link

lock bot commented May 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request 🔒 Outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants