Skip to content

Expand paths that use ~ to full path - #704

Merged
maebert merged 1 commit into
jrnl-org:masterfrom
minchinweb:hotfix-689a
Nov 8, 2019
Merged

maebert merged 1 commit into
jrnl-org:masterfrom
minchinweb:hotfix-689a

Conversation

@minchinweb

Copy link
Copy Markdown
Contributor

It seems that ~ (meaning the user directory) must be explicitly expanded when used on the configuration to successfully upgrade.

I can't test this directly, as I don't have a Mac system locally. I don't think there are any applicable tests to be written.

c.f issue #689

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?

@alichtman alichtman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@maebert
maebert merged commit 971560e into jrnl-org:master Nov 8, 2019
@minchinweb
minchinweb deleted the hotfix-689a branch November 9, 2019 20:22
@wren wren added the bug Something isn't working label Jan 10, 2020
@wren wren changed the title [Upgrade to 2.0] Expand User directory Expand paths that use ~ to full path Jan 10, 2020
wren pushed a commit that referenced this pull request Apr 18, 2020
@lock

lock Bot commented May 21, 2020

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot added the 🔒 Outdated label May 21, 2020
@lock lock Bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working 🔒 Outdated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants