Fix keyring issue on linux

[maebert]

This fixues issues with Keyring on Ubuntu and other Linux distros (fixes #654 #718 #558 #496 #478 #410 #407):

RuntimeError: No recommended backend was available. Install a recommended 3rd party backend package; or, install the keyrings.alt package if you want to use the non-recommended backends. See https://pypi.org/project/keyring for details.

This PR adds keyrings.alt as a requirement on linux. secretstorage might have the better and more complete interface to Gnome's keyring, but depends on libdbus to be installed, which we don't have control over.

Also see #699.

I tested this on Ubuntu 18.04 LTS, but can't more testing on different platforms would be nice.

Checklist

• The code change is tested and works locally.
• Tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?

[wren]

Keyrings in this package may have security risks or other implications. These backends were extracted from the main keyring project to make them available for those who wish to employ them, but are discouraged for general production use. Include this module and use its backends at your own risk.

😬

Is this really the best option we have to solve this?

[maebert]

Is this really the best option we have to solve this?

Alternatively, we could use Jeepney on Linux, which uses a pure-python DBus implementation to talk to SecretService. However, there's no promise that it's any more or less secure than the implementation in keyrings.alt...

[pspeter]

Alternatively, we could tell people in the documentation how to fix it themselves (install libdbus and secretstorage). It's probably better than people relying on insecure storage without even realizing that it's insecure.

Also, my PR #699 fixes some of the keyring issues you linked already (it shouldn't crash anymore when people select "no" to the keyring storage).

[wren]

I think we should avoid using anything that says we shouldn't use it in a production setting. Let's leave this out for now and update the docs to show how to fix manually.

We can also put in a link to the docs page when someone runs into the error, in order to be more helpful.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.