Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Travis-CI Testing #759

Merged
merged 7 commits into from
Nov 29, 2019
Merged

More Travis-CI Testing #759

merged 7 commits into from
Nov 29, 2019

Conversation

MinchinWeb
Copy link
Contributor

@MinchinWeb MinchinWeb commented Nov 28, 2019

This is to expand the Travis testing. Specifically, it adds:

  • Python 3.8 (on Linux) as an "allowable failure". See Add Python 3.8 support #739. It looks like an easy fix to get this working. Once working, this can removed from the allowable failure list.
  • the developmental version of Python (on Linux), as an allowable failure. This is designed as a forward-looking test to help us be aware of anything in the next Python version that might break jrnl. It also has the bonus of helping the Python core devs by exposing the cutting edge Python code to lots of real life Python code.
  • a test not in UTC. When I was re-adding the DayOne tests ([Dayone] re-add tests #742), I discovered that the code path changes depending on if the timezone is UTC or now. However, I expect few user's machines are set to UTC, so it seems like an oversight to to only test in UTC.
  • MacOS. Because why not? Runs under Python 3.7.4. We have had MacOS-specific bugs in the past (see Update tzlocal #130).
  • Windows, as an allowable failure. This is currently tested under Python 3.7, as on Python 3.8 poetry tries to install cryptography as a locally-built wheel (rather than a wheel downloaded from PyPI), which fails. This test currently times out after 10 minutes, as one of the behave steps is to open the editor and get text, and I think it is really opening the editor, rather than pretending to. This is odd, because it doesn't do this on my local machine.... c.f. Windows Support #619

I haven't implemented it here, but the format of Travis should make it simple to add stages to the testing sequence, for example to run all the code through black or check that the dependencies have all been updated.

Checklist

  • (n/a) The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?

@wren wren changed the base branch from master to develop November 29, 2019 14:20
@wren wren added the enhancement New feature or request label Nov 29, 2019
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I actually got up early this morning to do this exact thing, only to find you had already done most of it.

Thank you!

@wren wren merged commit b0b9c48 into jrnl-org:develop Nov 29, 2019
@MinchinWeb MinchinWeb deleted the more-travis branch December 2, 2019 18:11
@MinchinWeb
Copy link
Contributor Author

Glad to help!

@wren wren added build Issues related to the build pipeline and removed enhancement New feature or request labels Jan 10, 2020
@lock
Copy link

lock bot commented May 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Issues related to the build pipeline 🔒 Outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants