Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI config to only deploy once #761

Merged
merged 15 commits into from Nov 30, 2019

Conversation

wren
Copy link
Member

@wren wren commented Nov 29, 2019

Closes #757

This also does the following:

  • All tests run on Python 3.6, 3.7, and 3.8
  • Each Python version runs on Linux, Mac and Windows
  • Adds caching for Python versions installed by pyenv on mac, and choco on windows (speeds up builds considerably)

Todo (possibly in a separate PR):

  • Add caching for poetry install (would shave off another minute or so per test suite)
  • Look into why Windows python install is getting 503

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?

@wren wren changed the base branch from master to develop November 29, 2019 19:51
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@micahellison micahellison merged commit 864df05 into jrnl-org:develop Nov 30, 2019
@wren wren added the build Issues related to the build pipeline label Jan 10, 2020
@lock
Copy link

lock bot commented May 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
@wren wren deleted the travis-double-deploy-757 branch July 11, 2020 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Issues related to the build pipeline 🔒 Outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis attempts to deploy twice
2 participants