Black Formatter

[MinchinWeb]

This adds the black formatter as Linting stage to the Travis-CI setup. The existing code was also adjusted, as needed, to pass the linter.

This linting stage has to pass before the regular tests are run.

Checklist

• The code change is tested and works locally.
• Tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR. (Except for added comments, but then those aren't really code, are they?)
• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?

[wren]

Thanks for the PR. I'll review this on Tuesday (my next jrnl work day).

Small point of order: the contributing guidelines ask that we open a new issue for new features. This gives us a chance to talk about things before you put the work into implementing it. In this case, I do happen to like Black already, but please try to follow the guidelines in the future.

[MinchinWeb]

I created issue #770 as a place to have some discussion around this!

[wren]

Overall looks good. Just need a bit of cleaning up of the travis config.

[wren]

Hey, this is going to be very prone to merge conflicts, and I don't want you to try to hit a moving target. Can you take out the changes made by black itself, and just do the travis file and the fmt comments? I can run black when this gets merged so there are no conflicts.

[wren]

It is otherwise ready for approval, though. Thank you!

[MinchinWeb]

@wren I just updated it to the current 'develop' branch. Mostly as a way to get Travis-CI to run (maybe..). It should be a clean merge at the moment.

[MinchinWeb]

Black doesn't want to make any changes locally, but want to on Travis, so I added the --diff option to figure out why.

[wren]

Suggested change

	# We can override the default config on a by-journal basis
	# We can override the default config on a by-journal basis

[wren]

Approving so I can get this merged and fix the issues.

@MinchinWeb The problem, I'm guessing, is that you're running a different version of black than the build is on Travis. Make sure you're using poetry (e.g. poetry run black .) when running locally to ensure the same version.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.