Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for tests not handling successive input prompts #795

Closed
wants to merge 1 commit into from
Closed

Fix for tests not handling successive input prompts #795

wants to merge 1 commit into from

Conversation

dbxnr
Copy link
Contributor

@dbxnr dbxnr commented Jan 10, 2020

Refactor enabling behave to properly handle multiple successive inputs.

Previously a test with successive prompts wouldn't correctly iterate over the mock inputs, treating them as a single input. Single letter inputs are correctly parsed and iterated over. See tests in #796

Refactored some existing tests to be correctly handled as text.

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?

@dbxnr dbxnr mentioned this pull request Jan 10, 2020
7 tasks
@dbxnr dbxnr requested a review from wren January 21, 2020 16:31
@dbxnr
Copy link
Contributor Author

dbxnr commented Jan 21, 2020

This is necessary for #798 tests to pass

Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is causing the Windows tests to fail now. Do you know why that might be?

@wren
Copy link
Member

wren commented Jan 26, 2020

Ah, I see what's going on now.

The way to do successive input prompts is by putting each one on a new line. I left a comment in #796 to show how to do it.

I believe this is already working as intended, so I'm closing this out. Please let me know if I'm missing something.

@wren wren closed this Jan 26, 2020
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔒 Outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants