Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where jrnl would always out 'source' for version, fix Poetry config to build and publish properly #820

Merged
merged 4 commits into from Jan 25, 2020
Merged

Fix issue where jrnl would always out 'source' for version, fix Poetry config to build and publish properly #820

merged 4 commits into from Jan 25, 2020

Conversation

wren
Copy link
Member

@wren wren commented Jan 25, 2020

Changes:

  • update poetry version
  • add maintainer field to config
  • fix poetry warning
  • add version file to repo

micahellison
micahellison approved these changes Jan 25, 2020
View reviewed changes
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧐

@wren wren merged commit b71f8fc into jrnl-org:master Jan 25, 2020
@wren wren deleted the version-fix branch January 25, 2020 21:44
@micahellison micahellison added the build Issues related to the build pipeline label Jan 25, 2020
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@micahellison micahellison micahellison approved these changes

Assignees
No one assigned
Labels
build Issues related to the build pipeline 🔒 Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wren @micahellison