Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Python versions in pipeline #910

Merged
merged 7 commits into from Apr 11, 2020
Merged

Update Python versions in pipeline #910

merged 7 commits into from Apr 11, 2020

Conversation

MinchinWeb
Copy link
Contributor

@MinchinWeb MinchinWeb commented Apr 7, 2020 •
edited

Updates Python 3.7.5 to 3.7.7 and 3.8.0 to 3.8.2.
Also add the alpha 5 build of Python 3.9 as an allowable failure. Poetry doesn't support Python 3.9 yet. See python-poetry/poetry#2154

Checklist

  • [ n/a ] The code change is tested and works locally.
  • [ ? ] Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?

@MinchinWeb MinchinWeb changed the title [Travis] update WIndows Python versions [Travis] update Windows Python versions Apr 7, 2020
@MinchinWeb
[Travis] update Windows Python versions
fbd5f09 
Updates Python 3.7.5 to 3.7.7 and 3.8.0 to 3.8.2.
Also add the alpha 5 build of Python 3.9 as an allowable failure.
@MinchinWeb
[Travis] add Build Config Validations
0575def 
https://blog.travis-ci.com/2019-10-24-build-config-validation
micahellison
micahellison reviewed Apr 11, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml
@@ -96,7 +98,7 @@ jobs:
python: 3.7
env:
<<: *env_windows
JRNL_PYTHON_VERSION: 3.7.5
JRNL_PYTHON_VERSION: 3.7.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this PR update Python versions for all OSes instead of just Windows? Best to keep them all updated at once.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know where to find a list of the MasOS versions available? Windows versions are coming from Chocolatey, but I'd assumed that the MacOS versions were tied to the base image...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micahellison It looks like you can use Homebrew to install custom versions of Python, but that is beyond my experience... see http://www.pyslvs.com/blog/yuan_2018-09-22.html

The Travis documentation doesn't actually say what Python versions are available on what OSX images, just that at least one Python version will always be available.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Mac builds, you can set JRNL_PYTHON_VERSION without having to modify anything else. Python comes pre-installed on macOS, so the build uses pyenv install to install whatever version the JRNL_PYTHON_VERSION is set to.

wren
wren reviewed Apr 11, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
wren
wren requested changes Apr 11, 2020
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

@MinchinWeb
Copy link
Contributor Author

@wren @micahellison updated, as requested (other than the MacOS versions).

Changing the MacOS Python versions requires switching to Homebrew for installing Python, which is beyond my expertise.

This should be good to merge!

wren
wren approved these changes Apr 11, 2020
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wren wren merged commit 9299dcf into jrnl-org:develop Apr 11, 2020
@wren wren added the build Issues related to the build pipeline label Apr 11, 2020
@wren wren changed the title [Travis] update Windows Python versions Update Python versions in pipeline Apr 11, 2020
@MinchinWeb MinchinWeb deleted the windows-python-update branch April 12, 2020 02:31
wren added a commit that referenced this pull request Apr 18, 2020
@MinchinWeb @wren
Update Windows Python versions (#910)
e18bea9 
* [Travis] update Windows Python versions
* Update Python versions to be uniform across the board

Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
wren added a commit that referenced this pull request Apr 18, 2020
@MinchinWeb @wren
Update Windows Python versions (#910)
6917f12 
* [Travis] update Windows Python versions
* Update Python versions to be uniform across the board

Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
wren added a commit that referenced this pull request Jul 25, 2020
@MinchinWeb @wren
Update Windows Python versions (#910)
587de36 
* [Travis] update Windows Python versions
* Update Python versions to be uniform across the board

Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahellison micahellison micahellison left review comments

@wren wren wren approved these changes

Assignees
No one assigned
Labels
build Issues related to the build pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MinchinWeb @micahellison @wren