Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keyring version from "^19.0" to ">19.0, <22.0" #914

Merged
merged 6 commits into from Apr 11, 2020

Conversation

micahellison
Copy link
Member

Fixes #783 AUR packaging issue. I checked all dependencies for their latest versions, and only keyring had more recent versions, so I'm allowing all versions up to and including 21.x.

The other changes in the lockfile reflect updates to dependencies of dependencies when running poetry update.

Moving forward, we'll plan to do this exercise a couple times each year to take advantage of the latest updates to our dependencies.

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • [n/a] Have you written new tests for your core changes, as applicable?

Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥔

@wren wren added the enhancement New feature or request label Apr 11, 2020
@wren wren merged commit 4419279 into jrnl-org:develop Apr 11, 2020
@micahellison micahellison deleted the dependency-updates branch April 11, 2020 20:31
wren pushed a commit that referenced this pull request Apr 18, 2020
* #783 Allow keyring >19.0, <22.0 instead of ^19.0
wren pushed a commit that referenced this pull request Apr 18, 2020
* #783 Allow keyring >19.0, <22.0 instead of ^19.0
wren pushed a commit that referenced this pull request Jul 25, 2020
* #783 Allow keyring >19.0, <22.0 instead of ^19.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate support/automation for Arch Linux package deployment process
2 participants