Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow most recent pytz version and update dependencies #937

Merged
merged 1 commit into from May 5, 2020

Conversation

micahellison
Copy link
Member

See #783. This PR allows the most recent version of pytz and updates the lockfile to the most recent allowable versions from pyproject.toml.

The only impact of the pytz update is on DayOneJournal.py.

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass. --
    poetry run behave
  • The code passes linting via
    black (consistent code styling). --
    poetry run black --check . --verbose --diff
  • The code passes linting via pyflakes
    (logically errors and unused imports). -- poetry run pyflakes jrnl features
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • [n/a] Have you written new tests for your core changes, as applicable?

Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wren wren added the enhancement New feature or request label May 5, 2020
@wren wren merged commit 267698f into jrnl-org:develop May 5, 2020
@wren wren added build Issues related to the build pipeline and removed enhancement New feature or request labels May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants