Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lockbot comment to encourage linking to issue #941

Merged
merged 2 commits into from
May 22, 2020

Conversation

MinchinWeb
Copy link
Contributor

Further to #938.

Should starred/pushpinned issues be immune to being closed? I think that was the purpose of that label.

Also, I think the closing text should encourage people to link back to "this" issue, so the conversation can be followed.

Checklist

  • [ n/a ] The code change is tested and works locally.
  • [ n/a ] Tests pass. Your PR cannot be merged unless tests pass. --
    poetry run behave
  • [ n/a ] The code passes linting via
    black (consistent code styling). --
    poetry run black --check . --verbose --diff
  • [ n/a ] The code passes linting via pyflakes
    (logically errors and unused imports). -- poetry run pyflakes jrnl features
  • [ n/a ] There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • [ n/a ] Have you written new tests for your core changes, as applicable?

@wren
Copy link
Member

wren commented May 7, 2020

The lock bot only acts on closed issues, so there's no need to exempt any labels.

I like the addition to the comment, though.

@wren
Copy link
Member

wren commented May 7, 2020

To clarify, stalebot closes issues, and lockbot locks commenting after the issue is closed. The entire process takes about 5 months of no activity.

@MinchinWeb
Copy link
Contributor Author

Ok, this has been slimmed down to the just the comment on linking to the closed issue!

@wren wren added the build Issues related to the build pipeline label May 22, 2020
@wren wren changed the title Improvements to lockbot for Github comments Update lockbot comment to encourage linking to issue May 22, 2020
@wren wren merged commit 678a241 into jrnl-org:develop May 22, 2020
@MinchinWeb MinchinWeb deleted the lockbot branch May 22, 2020 19:23
wren pushed a commit that referenced this pull request Jul 25, 2020
* improvements to lockbot for Github comments
* [lockbot] just the comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants