Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create journal with absolute path when no path is specified #972

Merged
merged 11 commits into from Jun 13, 2020
Merged

Create journal with absolute path when no path is specified #972

merged 11 commits into from Jun 13, 2020

Conversation

eshrh
Copy link
Contributor

@eshrh eshrh commented May 29, 2020

Intended to close #860.

During installation, make sure the journal path is added to the config as an absolute path. I think prepending ~/ as @micahellison mentioned is very unexpected.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have you written new tests for these changes, as needed.
  • All tests pass.

micahellison
micahellison requested changes May 30, 2020
View reviewed changes
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Very simple, clean, and elegant. Besides the small issue of the unused "there is no config" step, I think it looks great.

features/steps/core.py Outdated Show resolved Hide resolved
@eshrh
Copy link
Contributor Author

eshrh commented May 30, 2020

@micahellison done. I was having some serious problems with the testing lol, I tried way too many hacks

@micahellison micahellison added the bug Something isn't working label Jun 6, 2020
micahellison
micahellison previously approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

micahellison
micahellison approved these changes Jun 13, 2020
View reviewed changes
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@micahellison micahellison changed the title Create installation journal with absolute path Create journal with absolute path when no path is specified Jun 13, 2020
@micahellison micahellison merged commit 9668760 into jrnl-org:develop Jun 13, 2020
@eshrh eshrh deleted the change-cwd-bug branch June 13, 2020 18:47
wren pushed a commit that referenced this pull request Jul 25, 2020
@eshrh
Create journal with absolute path when no path is specified (#972)
2a3fd82 
* create jrnl with abspath

Co-authored-by: = <esrh@netc.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahellison micahellison micahellison approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jrnl allows pathless journal files and loses journal when users changes current directory
3 participants
@eshrh @micahellison @wren