Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] run tests only with supported django and python versions #110

Merged
merged 1 commit into from Oct 22, 2022

Conversation

jairhenrique
Copy link
Contributor

This test matrix proposal is based on https://endoflife.date/django

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #110 (bd8a954) into master (8e941fe) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         1209      1209           
=========================================
  Hits          1209      1209           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jrobichaud
Copy link
Owner

Since the beginning of the project I had this in mind:

  1. keep the compatibility until there are breaking changes (Ex: threadlocal vs contextvars) or the maintainability is unbearable (Ex: I kept python 3.4 for a long time)
  2. drop support with documented incompatibility in a notable release

Does that sound ok to you?

I am open to discussion.

@jairhenrique
Copy link
Contributor Author

@jrobichaud makes senses, but why support libraries and versions of python who doesn't have support anymore?

I think removing support for these versions encourages and force the community to keep their environment up to date.

@jrobichaud jrobichaud merged commit 557e5e0 into jrobichaud:master Oct 22, 2022
@jairhenrique jairhenrique deleted the only-active branch October 22, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants