Handle PermissionDenied like Http404 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django's permission denied should be handled by handler403 defined in the urls.py and in this case it would return a 403 rather than a 500
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
===========================================
- Coverage 100.00% 99.58% -0.42%
===========================================
Files 42 42
Lines 1162 1199 +37
===========================================
+ Hits 1162 1194 +32
- Misses 0 5 +5
Continue to review full report at Codecov.
|
rabbit-aaron
changed the title
jrobichaud
approved these changes
Sep 1, 2021
|
@rabbit-aaron thank you for your contribution. It is released in 2.1.2. I credited you in the change log as I do normally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django's PermissionDenied is used very similar to the Http404, I think that should be handled the same way.
here's the doc:
https://docs.djangoproject.com/en/3.2/ref/urls/#handler403
https://docs.djangoproject.com/en/3.2/ref/views/#django.views.defaults.permission_denied