Remove DRF dependency #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#7 made use of DRF's `HTTP_500_INTERNAL_SERVER_ERROR` without adding it as a dependency. However that's a fairly large dependency get the literal value `500`. This removes the dependency and uses the literal int.
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 38 38
Lines 722 721 -1
=====================================
- Hits 722 721 -1
Continue to review full report at Codecov.
|
meshy
approved these changes
Sep 4, 2019
jrobichaud
approved these changes
Sep 4, 2019
|
Thank you, I missed that. |
|
Fixed in 1.3.1. |
|
I just credited you properly in release notes of 1.3.1. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7 made use of DRF's
HTTP_500_INTERNAL_SERVER_ERRORwithout adding it as a dependency. However that's a fairly large dependency get the literal value500. This removes the dependency and uses the literal int.