Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility #22

Closed
LemonBoy opened this issue Sep 11, 2016 · 4 comments
Closed

Python 3 compatibility #22

LemonBoy opened this issue Sep 11, 2016 · 4 comments

Comments

@LemonBoy
Copy link
Contributor

When calling os.open here the octal number 0644 should be written as 0o644, otherwise python3 raises a SyntaxError: invalid token.
The same syntax works fine as far as I can see in python2.

@LemonBoy
Copy link
Contributor Author

LemonBoy commented Sep 14, 2016

Ok, I actually tried to use it and found you need some more adjustments.

@jrosdahl
Copy link
Owner

Ok, I actually tried to use it and found you need some more adjustments.

Ah, I assumed you had tried it so I jumped the gun and added Python 3 compatibility notes in README and CHANGES. I'll revert those for now.

Here is a patch that seemingly works.

Thanks, but that patch breaks Python 2 support. You can check Python 2 compatibility by running the test suite (./test). Replace /usr/bin/env python with /usr/bin/env python3 in miniircd to run the test suite against Python 3.

@jrosdahl jrosdahl reopened this Sep 14, 2016
@jrosdahl jrosdahl changed the title Small problem with python3 Python 3 compatibility Sep 14, 2016
@jrosdahl
Copy link
Owner

@LemonBoy: Are you interested in working on properly supporting both Python 2 and 3? Otherwise, I think it's time to close the issue.

@jrosdahl
Copy link
Owner

Fixed in #28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants