Support for compiling with ninja on Windows

[jrouwe]

No description provided.

[mihe]

Just to clarify, the issue here isn't with Ninja per se and more of an issue with compiling with the Windows-native version of clang++, as opposed to something like clang-cl. I've been using Ninja on all platforms for Godot Jolt since the beginning, but with clang-cl as the compiler on Windows.

Anyway, this doesn't seem to work quite right just yet. You'll need to use if (MSVC) in these three places as well:

JoltPhysics/Build/CMakeLists.txt

Lines 234 to 236 in d0a5839

	if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows" AND NOT MINGW)
	target_link_options(UnitTests PUBLIC "/SUBSYSTEM:CONSOLE")
	endif()

JoltPhysics/Build/CMakeLists.txt

Lines 260 to 262 in d0a5839

	if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows" AND NOT MINGW)
	target_link_options(HelloWorld PUBLIC "/SUBSYSTEM:CONSOLE")
	endif()

JoltPhysics/Build/CMakeLists.txt

Lines 271 to 273 in d0a5839

	if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows" AND NOT MINGW)
	target_link_options(PerformanceTest PUBLIC "/SUBSYSTEM:CONSOLE")
	endif()

Then there's also the problem of what to do with the -pthread flag, since that one doesn't make a whole lot of sense when compiling on Windows, which leads Clang to emit a warning about unused arguments, which becomes an error.

I suppose you can choose to either not add that flag when "${CMAKE_SYSTEM_NAME}" STREQUAL "Windows", or just throw in -Qunused-arguments when "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang", much like what's already being done for clang-cl on Windows:

JoltPhysics/Build/CMakeLists.txt

Line 126 in d0a5839

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Qunused-arguments") # Clang emits warnings about unused arguments such as /MP and /GL

With those changes I can successfully build and run all of Jolt's applications with the Ninja Multi-Config generator and CMAKE_CXX_COMPILER=clang++.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[mihe]

It struck me just now that maybe MinGW still needs the -pthread flag? I'm not very familiar with how the runtime stuff work there.

[jrouwe]

Apparently not: