Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Unsubscribe rxjs and tweak dependencies #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

waratah
Copy link
Contributor

@waratah waratah commented Sep 12, 2022

I'm submitting a...

  • [X ] Bug Fix
  • Feature
  • Other (Refactoring, Added tests, Documentation, ...)

Description

The rxjs subcription will not always disappear leaving a memory leak.

Resolve some dependency issues - could not compile source

Added lookup or reload of the list when the value is cleared.

Does this PR introduce a breaking change?

  • [X ] Yes
  • No

Does this PR affects any existing issues?

  • Yes
  • [ X] No

if yes mention the issue number and what kind of change it is
for example: closes #1, fixes #1, etc.,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency issue
1 participant