Fix for keyboard highlighting of selections #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using keyboard arrow up/down to highlight items where there are more suggestions than can be displayed by the maxResults parameter, the highlight disappears but is still selecting an item, allowing selection of a non-visible suggestion. This limits keyboard highlighting to the lesser of the number of suggestions or the value of maxResults.
Added export for AutoCompleteStyles to allow for creation of object that can be shared where multiple instances of the component need shared styling.
|
Merged and released. Thanks for the help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a...
Description
Fixes an issue where the keyboard up/down arrow is used to highlight a selection.
At the moment the highlight is bound to the number of suggestions, but the
maxResultsparameter means that not all suggestions are visible.As a result it is possible to move the highlight beyond the visible suggestions, which will then result in a non-visible suggestion being selected when the user presses enter/tab to leave the field.
This fix prevents the keyboard up/down arrow from moving beyond the visible suggestions.
Also, adding export for
AutoCompleteStylesobject to allow creation of object that can be shared between several fields.Does this PR introduce a breaking change?
Does this PR affects any existing issues?