Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File size unit is wrong #59

Closed
mwmw7 opened this issue Feb 2, 2023 · 1 comment
Closed

File size unit is wrong #59

mwmw7 opened this issue Feb 2, 2023 · 1 comment

Comments

@mwmw7
Copy link

mwmw7 commented Feb 2, 2023

// https://raw.githubusercontent.com/jrquick17/ng-speed-test/02c59e4afde67c35a5ba74014b91d44b33c0b3fe/demo/src/assets/500kb.jpg
// 500kb      // 408949 kb

I think 408949 bytes is right

README and comments have wrong unit

image

@jrquick17
Copy link
Owner

This is a known discrepancy which we do call out in the README.
dgns

The code does use the exact byte size so the speed checks out of the box should be accurate. Ideally the image would be exactly 500kb but not a priority at the moment. If you have images that match then feel free to submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants