Fixed Master Mode PCB (connected GND pins) #127
Conversation
Connected trace to rear ground plane.
jrsteensen
added
Type: Bug/Obsolesce
jrsteensen
added this to In progress
in End Item: Upper Instrument Panel HW
via automation
|
Odd I'll take a look. I suspect it is just the ground plane not attached to
ground
…On Thu, Dec 12, 2019, 08:16 John Steensen ***@***.***> wrote:
Connected trace to rear ground plane.
Description
Added 24mil trace between pins 5&6, connecting trace to ground plane.
Require new manufacturing file generation.
Addresses #126 <#126>
Type of change
Please delete options that are not relevant.
- Change ECAD (fixed issue with existing PCB)
Checklist: (Delete non-relevant sections) PCB/ECAD:
- Requirements definition
- Schematic completed
- PCB routed
- PCB constrained by physical footprint limitations
- PCB critical component location requirements met
- Schematic/PCB reviewed
- BOM generated
- Gerbers generated
- MCAD generated
------------------------------
You can view, comment on, or merge this pull request online at:
#127
Commit Summary
- Added 24mil trace between pins 5 & 6
File Changes
- *M* ECAD/PCBs for Sim/Master Mode
Pushbutton/MasterModePushbutton.kicad_pcb
<https://github.com/jrsteensen/OpenHornet/pull/127/files#diff-0>
(1896)
- *M* ECAD/PCBs for Sim/Master Mode
Pushbutton/MasterModePushbutton.kicad_pcb-bak
<https://github.com/jrsteensen/OpenHornet/pull/127/files#diff-1>
(1783)
Patch Links:
- https://github.com/jrsteensen/OpenHornet/pull/127.patch
- https://github.com/jrsteensen/OpenHornet/pull/127.diff
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#127?email_source=notifications&email_token=AC7IBPIMHFDXQIODTCVKWRTQYJPT7A5CNFSM4J2BAMY2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IADEMNQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC7IBPMPH5VGNNVQ6JUKAX3QYJPT7ANCNFSM4J2BAMYQ>
.
|
Already fixed, that was the issue. Need this pull request reviewed, merged and manufacturing files generated. |
|
Will push tonight. Literally 4-5 click fix + gerbers
…On Thu, Dec 12, 2019, 09:08 John Steensen ***@***.***> wrote:
Odd I'll take a look. I suspect it is just the ground plane not attached
to ground
… <#m_3269852706584567628_>
On Thu, Dec 12, 2019, 08:16 John Steensen *@*.***> wrote: Connected trace
to rear ground plane. Description Added 24mil trace between pins 5&6,
connecting trace to ground plane. Require new manufacturing file
generation. Addresses #126
<#126> <#126
<#126>> Type of change
Please delete options that are not relevant. - Change ECAD (fixed issue
with existing PCB) Checklist: (Delete non-relevant sections) PCB/ECAD: -
Requirements definition - Schematic completed - PCB routed - PCB
constrained by physical footprint limitations - PCB critical component
location requirements met - Schematic/PCB reviewed - BOM generated -
Gerbers generated - MCAD generated ------------------------------ You can
view, comment on, or merge this pull request online at: #127
<#127> Commit Summary -
Added 24mil trace between pins 5 & 6 File Changes - *M* ECAD/PCBs for
Sim/Master Mode Pushbutton/MasterModePushbutton.kicad_pcb
https://github.com/jrsteensen/OpenHornet/pull/127/files#diff-0 (1896) -
*M* ECAD/PCBs for Sim/Master Mode
Pushbutton/MasterModePushbutton.kicad_pcb-bak
https://github.com/jrsteensen/OpenHornet/pull/127/files#diff-1 (1783)
Patch Links: - https://github.com/jrsteensen/OpenHornet/pull/127.patch -
https://github.com/jrsteensen/OpenHornet/pull/127.diff — You are
receiving this because your review was requested. Reply to this email
directly, view it on GitHub <#127
<#127>?email_source=notifications&email_token=AC7IBPIMHFDXQIODTCVKWRTQYJPT7A5CNFSM4J2BAMY2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IADEMNQ>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC7IBPMPH5VGNNVQ6JUKAX3QYJPT7ANCNFSM4J2BAMYQ
.
Already fixed, that was the issue. Need this pull request reviewed, merged
and manufacturing files generated.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#127?email_source=notifications&email_token=AC7IBPNZ2NIBWHXKEXWDCDLQYJVZZA5CNFSM4J2BAMY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGXLGWQ#issuecomment-565097306>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC7IBPOO2NKDZER3YDNEYEDQYJVZZANCNFSM4J2BAMYQ>
.
|
|
@jrsteensen the fix was done incorrectly. For future reference, the correct way to fix these issues is to fix them in schematic (already done)., then on pcbnew there is a button to update PCB from schematic. I will generate the gerber files no other change is required. @balzreber @jrsteensen please review once you see my commit |
1 similar comment
|
@jrsteensen the fix was done incorrectly. For future reference, the correct way to fix these issues is to fix them in schematic (already done)., then on pcbnew there is a button to update PCB from schematic. I will generate the gerber files no other change is required. @balzreber @jrsteensen please review once you see my commit |
published updated gerber files. removed bak file
Connected trace to rear ground plane.
Description
Added 24mil trace between pins 5&6, connecting trace to ground plane. Require new manufacturing file generation.
Addresses #126
Type of change
Please delete options that are not relevant.
Checklist: (Delete non-relevant sections)
PCB/ECAD: