Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue#20] added nano lite board #46

Merged
merged 2 commits into from
Oct 23, 2019
Merged

[issue#20] added nano lite board #46

merged 2 commits into from
Oct 23, 2019

Conversation

amanuense
Copy link
Collaborator

this board measures 50x35mm, doesn't contain 12v rail.

Addresses #20

Type of change

Please delete options that are not relevant.

  • New MCAD (new Mechanical Model)
  • Change MCAD (fixed issue with existing MCAD model)
  • New ECAD (new PCB)
  • Change ECAD (fixed issue with existing PCB)
  • New software module (new software module for slave)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

PCB/ECAD:

  • Requirements definition captured
  • Schematic created
  • Netlist created
  • PCB Routed
  • PCB constrained by physical footprint limitations
  • PCB critical component location requirements met

[issue#20] added nano lite board
fa5eaa9 
this board measures 50x35mm, doesn't contain 12v rail.
jrsteensen
jrsteensen reviewed Oct 21, 2019
View reviewed changes
Copy link
Owner

@jrsteensen jrsteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ECAD looks good. Has SolidWorks (MCAD) model been updated to reflect the Lite?

@jrsteensen jrsteensen added this to In progress in End Item: Top Level Assembly via automation Oct 21, 2019
@jrsteensen jrsteensen added this to the 7) Top Level Assembly milestone Oct 21, 2019
@jrsteensen jrsteensen added Category: ECAD Electrical CAD/PCB HW Design Priority: Critical Status: Under Review already reviewed by some maintainer and waiting for the final decision/feedback from the PR author Type: Enhancement New feature or request labels Oct 21, 2019
@amanuense
Copy link
Collaborator Author

amanuense commented Oct 21, 2019 via email

End Item: Top Level Assembly automation moved this from In progress to Review in progress Oct 21, 2019
jrsteensen
jrsteensen requested changes Oct 21, 2019
View reviewed changes
Copy link
Owner

@jrsteensen jrsteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and delete out the SLDPRT and SLDASM files from the branch, and we can merge this.

[issue#20] added nano lite board
dabe207 
this board measures 50x35mm, doesn't contain 12v rail.
@amanuense
Copy link
Collaborator Author

updated branch. removed SLDPRT and SLDASM files

End Item: Top Level Assembly automation moved this from Review in progress to Reviewer approved Oct 23, 2019
@jrsteensen jrsteensen merged commit 8dbfb51 into master Oct 23, 2019
End Item: Top Level Assembly automation moved this from Reviewer approved to Done Oct 23, 2019
@jrsteensen jrsteensen deleted the nano_lite branch October 23, 2019 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrsteensen jrsteensen jrsteensen approved these changes

Assignees

@amanuense amanuense

Labels
Category: ECAD Electrical CAD/PCB HW Design Priority: Critical Status: Under Review already reviewed by some maintainer and waiting for the final decision/feedback from the PR author Type: Enhancement New feature or request
Projects
No open projects
End Item: Top Level Assembly
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amanuense @jrsteensen