Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFG Files: OH3A1A1-1 - ASSYMFG Files: OH3A1A1-1 - ASSY, MAIN CENTER T… #828

Conversation

Arribe
Copy link
Contributor

@Arribe Arribe commented May 21, 2023

Description

Manufacturing files created for OH3A1A1-1 - ASSY, MAIN CENTER TUB.

Addresses #764

File generation

OH Wiki HOWTO Link

  • Generate SVG files (if required.)
  • Generate 3MF files (if required.)
  • Generate STEP files (if required.)
  • Copy the relevant decal PDFs from the art folder to the relevant manufacturing folder (if required.)

Review your files

  • Verify against drawing parts list that all the relevant manufacturing files have been created.
  • Open each SVG in your browser and compare against part to ensure it appears the same and its filename is correct.
  • Open each 3MF in a slicer of your choice and verify geometry matches F360 model and its filename is correct.
  • Open each STEP in a STEP file viewer of your choice and verify geometry matches F360 model and its filename is correct.

Submit your files

  • Create a github PR against the beta 1 branch with the manufacturing files located in correct location of the release folder.
  • Request a review of the PR.

Copy link
Owner

@jrsteensen jrsteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. -110 & -XXX Rubber is cut to length, not machined. I don't think it would need a MFG file, but certainly not a step - SVG if we think a SVG file is good.
  2. Please ensure all filenames are in all caps IAW build package requirements.

@jrsteensen jrsteensen added Type: Documentation Improvements or additions to documentation Category: MCAD Mechanical CAD labels May 21, 2023
@jrsteensen jrsteensen added this to the v1.0.0-beta1 (Beta 1) milestone May 21, 2023
@Arribe
Copy link
Contributor Author

Arribe commented May 21, 2023

fixes applied

Copy link
Owner

@jrsteensen jrsteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@jrsteensen jrsteensen merged commit 22aad6d into jrsteensen:v1.0.0-beta1 May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: MCAD Mechanical CAD Type: Documentation Improvements or additions to documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants