Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MANUFACTURING.md #980

Merged

Conversation

Arribe
Copy link
Contributor

@Arribe Arribe commented Aug 25, 2023

Fixed typo on parts ordering section, step 4.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Addresses #979

Type of change

Please delete options that are not relevant.

  • New MCAD (new Mechanical Model)
  • Change MCAD (fixed issue with existing MCAD model)
  • New ECAD (new PCB)
  • Change ECAD (fixed issue with existing PCB)
  • New software module (new software module for slave)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist: (Delete non-relevant sections)

MCAD:

  • Model is in SolidWorks 2019 format
  • Design intent and requirements have been met
  • Design has been fit checked to ensure no interferences exist
  • Design has been integrated into Next Higher Assembly (NHA)

PCB/ECAD:

  • Requirements definition
  • Schematic completed
  • PCB routed
  • PCB constrained by physical footprint limitations
  • PCB critical component location requirements met
  • Schematic/PCB reviewed
  • BOM generated
  • Gerbers generated
  • MCAD generated

Software:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Fixed typo on parts ordering section, step 4.
@jrsteensen jrsteensen added Type: Bug/Obsolesce Something isn't working/Part no longer available for sale Type: Documentation Improvements or additions to documentation Priority: Low This item is a low priority. labels Aug 25, 2023
@jrsteensen jrsteensen added this to the v1.0.0-beta1 (Beta 1) milestone Aug 25, 2023
@jrsteensen jrsteensen merged commit 6754270 into jrsteensen:v1.0.0-beta1 Aug 25, 2023
@Arribe Arribe deleted the PCB-manufacturing-guide-fix branch February 26, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low This item is a low priority. Type: Bug/Obsolesce Something isn't working/Part no longer available for sale Type: Documentation Improvements or additions to documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants