Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import user's collection #18

Open
jrtibbetts opened this issue Jul 13, 2018 · 0 comments
Open

Import user's collection #18

jrtibbetts opened this issue Jul 13, 2018 · 0 comments
Assignees
@jrtibbetts
Labels
enhancement New feature or request
Projects
SwiftDiscogs

Comments

@jrtibbetts
Copy link
Owner

Since there's no API for requesting a full collection database dump and then ingesting it, I think we just have to retrieve everything one page at a time.
@jrtibbetts jrtibbetts added the enhancement New feature or request label Jul 13, 2018
@jrtibbetts jrtibbetts self-assigned this Jul 13, 2018
@jrtibbetts jrtibbetts added this to To do in SwiftDiscogs via automation Jul 13, 2018
@jrtibbetts jrtibbetts moved this from To do to In progress in SwiftDiscogs Jul 13, 2018
@jrtibbetts jrtibbetts moved this from In progress to To do in SwiftDiscogs Jul 13, 2018
@jrtibbetts jrtibbetts moved this from To do to In progress in SwiftDiscogs Jul 15, 2018
@jrtibbetts jrtibbetts moved this from In progress to To do in SwiftDiscogs Jul 15, 2018
@jrtibbetts jrtibbetts moved this from To do to In progress in SwiftDiscogs Nov 6, 2018
@jrtibbetts jrtibbetts moved this from In progress to To do in SwiftDiscogs Nov 6, 2018
@jrtibbetts jrtibbetts moved this from To do to In progress in SwiftDiscogs Apr 18, 2019
jrtibbetts added a commit that referenced this issue Apr 21, 2019
@jrtibbetts
#18: Added the iTunes media service to the ThirdPartyServicesViewCont…
bec86ef 
…roller.
jrtibbetts added a commit that referenced this issue Apr 21, 2019
@jrtibbetts
#18: Added the Discogs service description from the Discogs About Us …
d714d1d 
…site.
jrtibbetts added a commit that referenced this issue Apr 22, 2019
@jrtibbetts
#18: Added some more properties and functions to the ImportableServic…
836cb0b 
…e protocol, and implemented them on DiscogsService and MediaLibraryService.
jrtibbetts added a commit that referenced this issue Apr 22, 2019
@jrtibbetts
#18: Removed the unused ArtistsViewController.importDatabases().
4c1955d
jrtibbetts added a commit that referenced this issue Apr 22, 2019
@jrtibbetts
#18: Implemented ThirdPartyServicesViewController.startOrStopImportin…
b6d9fdf 
…gTapped().
jrtibbetts added a commit that referenced this issue Apr 22, 2019
@jrtibbetts
#18: Changed ImportableService.updated(importProgress:,forService:) t…
8ad2641 
…o .update(importedItemCount:,totalItemCount:,forService) and implemented it everywhere. The import progress bar in the cell now updates correctly.
jrtibbetts added a commit that referenced this issue Apr 22, 2019
@jrtibbetts
#18: Renamed DiscogsService.importRelease() to importItem().
f31d2eb
jrtibbetts added a commit that referenced this issue Apr 22, 2019
@jrtibbetts
#18: Created subgroups for the Discogs and iTunes services.
d9f3d53
jrtibbetts added a commit that referenced this issue Apr 22, 2019
@jrtibbetts
#18: Reformatted some mock JSON files.
bb0347e
jrtibbetts added a commit that referenced this issue Apr 22, 2019
@jrtibbetts
#18: Started to add a Discogs Core Data model.
79cb4c0
jrtibbetts added a commit that referenced this issue Apr 22, 2019
@jrtibbetts
#18: Reformatted the rest of the mock JSON files.
d5501ac
jrtibbetts added a commit that referenced this issue Apr 22, 2019
@jrtibbetts
#18: Renamed the data model's CustomField.public property to isPublic…
bc8b254 
…, because public is a keyword, of course. :)
jrtibbetts added a commit that referenced this issue Apr 22, 2019
@jrtibbetts
#18: Renamed the AppDelegate.persistentContainer to medi8Container to…
6bf3805 
… distinguish it from the new Discogs container that I'm about to create.
jrtibbetts added a commit that referenced this issue Apr 24, 2019
@jrtibbetts
#18: Copied the Med8 persistent container code from AppDelegate into …
394c88b 
…a DiscogsContainer, then modified it for the Discogs collection data model.
jrtibbetts added a commit that referenced this issue Apr 24, 2019
@jrtibbetts
#18: Removed the context parameter from the ImportableService.importD…
9c3c700 
…ata(intoContext:) function.
jrtibbetts added a commit that referenced this issue Apr 24, 2019
@jrtibbetts
#18: Implemented adding Discogs collection folders and folder items. …
ab0a4ae 
…There's still a runtime crash because it can't find the Folder entity type, though.
jrtibbetts added a commit that referenced this issue Apr 24, 2019
@jrtibbetts
#18: Fixed the DiscogsService.fetchOrCreateFolder() error--I was crea…
0376e6b 
…ting a fetch request for the wrong entity type! 🤦‍♂️
jrtibbetts added a commit that referenced this issue Apr 24, 2019
@jrtibbetts
#18: Fixed a ridiculous logic error when updating the DiscogsService …
530db3f 
…progress bar.
jrtibbetts added a commit that referenced this issue Apr 24, 2019
@jrtibbetts
#18: The importProgress property is now set correctly, and since it f…
48e1477 
…ires the call to the import delegate, the explicit import delegate call has been removed.
jrtibbetts added a commit that referenced this issue Apr 24, 2019
@jrtibbetts
#18: The context is now saved after each folder batch has been imported.
bbb96da
jrtibbetts added a commit that referenced this issue May 1, 2019
@jrtibbetts
#18: Fixed DiscogsCollectionImporter.importDiscogsCustomFields>.
e57358d
jrtibbetts added a commit that referenced this issue May 1, 2019
@jrtibbetts
#18: Temporarily removed a warning.
bace6e1
jrtibbetts added a commit that referenced this issue May 1, 2019
@jrtibbetts
#18: Added an empty DiscogsCollectionImporterTests.
606b91e
jrtibbetts added a commit that referenced this issue May 1, 2019
@jrtibbetts
#18: DiscogsCollectionImporter.importDiscogsCollection() now returns …
b2c4360 
…a Promise, and the unit tests wait for that promise.
jrtibbetts added a commit that referenced this issue May 1, 2019
@jrtibbetts
#18: Fixed DiscogsCollectionImporter.importDiscogsFolders(). Thanks, …
ada0735 
…unit tests!
jrtibbetts added a commit that referenced this issue May 1, 2019
@jrtibbetts
#18: The userName is now passed into each of the import*() functions.…
841d941 
… It's just safer and easier to do it this way, instead of trying to make it an implicitly-unwrapped Optional property or throwing an error if it's nil.
jrtibbetts added a commit that referenced this issue May 1, 2019
@jrtibbetts
#18: Added an expectedItemCount to Folder to capture the Discogs Coll…
2e7c324 
…ectionFolder.count value.
jrtibbetts added a commit that referenced this issue May 1, 2019
@jrtibbetts
#18: Documented the error cases.
b82e2de
jrtibbetts added a commit that referenced this issue May 1, 2019
@jrtibbetts
#18: DiscogsCollectionImporter.importDiscogsItems() now imports only …
eda00b7 
…the master folder's items.
jrtibbetts added a commit that referenced this issue May 4, 2019
@jrtibbetts
#18: Made the various DiscogsCollectionImporter functions and typeali…
9196e14 
…ases public so that they can be tested individually.
jrtibbetts added a commit that referenced this issue May 4, 2019
@jrtibbetts
#18: More DiscogsCollectionImporter refactoring.
98cd8d1
jrtibbetts added a commit that referenced this issue May 4, 2019
@jrtibbetts
#18: Added the then clause for downloading all Discogs items in the m…
04713f5 
…aster folder.
jrtibbetts added a commit that referenced this issue May 4, 2019
@jrtibbetts
#18: Bumped the timeout for DiscogsCollectionImporterTests.testImport…
e029299 
…DiscogsCollectionWithValidUserNameOk() back to 20 seconds.
jrtibbetts added a commit that referenced this issue May 5, 2019
@jrtibbetts
#18: Added DiscogsCollectionImporter.createCoreDataItems() and an ext…
52abb5f 
…ension to Int that adds a times property and times() function.
jrtibbetts added a commit that referenced this issue May 5, 2019
@jrtibbetts
#18: Added properties for the core data fields, folders, and items, k…
c7b5123 
…eyed by their IDs, in order to cache things between promises.
jrtibbetts added a commit that referenced this issue May 7, 2019
@jrtibbetts
#18: Updated to Stylobate 0.20.2 and Kingfisher 5.4.0.
1db936c
jrtibbetts added a commit that referenced this issue May 7, 2019
@jrtibbetts
#18: Moved the fetchOrCreate() in DiscogsService over to the Stylobat…
f867334 
…e project.
jrtibbetts added a commit that referenced this issue May 7, 2019
@jrtibbetts
#18: Commented out most of the body of DiscogsCollectionImporter.crea…
1aca89a 
…teCoreDataItems() because it's crashing with an error I don't understand.
jrtibbetts added a commit that referenced this issue May 7, 2019
@jrtibbetts
#18: Figured out that a malformed predicate was causing the crash.
a7e520d
jrtibbetts added a commit that referenced this issue May 7, 2019
@jrtibbetts
#18: DiscogsService now uses the DiscogsCollectionImporter instead of…
c0fad64 
… its own import functions.
jrtibbetts added a commit that referenced this issue May 8, 2019
@jrtibbetts
#18: Added the ImporterDelegate to the DiscogsCollectionImporter, too.
f986166
jrtibbetts added a commit that referenced this issue May 11, 2019
@jrtibbetts
#18: Simplified some of the import logic.
1a7f552
jrtibbetts added a commit that referenced this issue May 11, 2019
@jrtibbetts
Revert "#18: Simplified some of the import logic."
0e875a0 
This reverts commit 1a7f552.
jrtibbetts added a commit that referenced this issue May 11, 2019
@jrtibbetts
#18: That's better.
04c2dc2
jrtibbetts added a commit that referenced this issue May 11, 2019
@jrtibbetts
#18: Removed DiscogsCollectionImporter.discogsFolders(), because it w…
c3cf37f 
…as doing exactly what Discogs.collectionFolders() does!
jrtibbetts added a commit that referenced this issue May 12, 2019
@jrtibbetts
#18: Improved the print() statements.
edc63df
jrtibbetts added a commit that referenced this issue May 12, 2019
@jrtibbetts
#18: addCoreDataItemsToOtherFolders() now returns a Promise<Void>.
e6b0405
jrtibbetts added a commit that referenced this issue May 14, 2019
@jrtibbetts
#18: All of the Importer's *ByID arrays now just take regular Int key…
fa673df 
…s, not Int16s and Int64s.
jrtibbetts added a commit that referenced this issue May 14, 2019
@jrtibbetts
#18: All import functions are now performed on a separate queue.
c4d6da0
jrtibbetts added a commit that referenced this issue May 15, 2019
@jrtibbetts
#18: Custom fields are now imported for all items. Yay!
2eb80a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrtibbetts jrtibbetts

Labels
enhancement New feature or request
Projects
SwiftDiscogs
  
In progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrtibbetts