Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GemInstaller would need nicer API #8

Open
mkristian opened this issue Aug 23, 2015 · 2 comments
Open

GemInstaller would need nicer API #8

mkristian opened this issue Aug 23, 2015 · 2 comments
Labels
enhancement

Comments

@mkristian
Copy link
Contributor

https://github.com/jruby-gradle/jem/blob/master/src/main/java/com/github/jrubygradle/jem/JemsClassLoader.java#L34

would need some API change to accommodate the above usecase in nicer way
@rtyler
Copy link
Member

rtyler commented Aug 23, 2015

@mkristian considering this code is using the internal (aka private) GemInstaller implementation, I'm not sure what niceness you're expecting :)

The main GemInstaller interface I definitely agree needs more API to flesh out, e.g. #6

@rtyler
Copy link
Member

rtyler commented Aug 23, 2015

@mkristian perhaps what would be a useful way forward here would be for you to suggest an API by writing an interface class and pasting it into this issue? Then we could discuss further?

@mkristian mkristian reopened this Aug 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtyler @mkristian