This repository has been archived by the owner on May 19, 2019. It is now read-only.
implement a JRubyJar task #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import org.gradle.api.execution.TaskExecutionGraph | ||
| import org.gradle.api.tasks.TaskState | ||
| import org.gradle.api.tasks.bundling.Zip | ||
| //import org.gradle.jvm.tasks.Jar |
There was a problem hiding this comment.
Try org.gradle.api.tasks.bundling.Jar
| include script.name | ||
| rename { 'jar-bootstrap.rb' } | ||
| void initScript(final Object scriptName) { | ||
| if (this.scriptName != null) { |
There was a problem hiding this comment.
I am not sure about this:
- Preventing the user from setting the scriptName twice is not very gradlesque (there are reasons for having to do this in complex builds).
- I think the evaluation is happening too early. the conversion should probably only happen when the task is executed.
I might actually be quite wrong in this case - I need to play with this code change first
This was referenced May 19, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.