Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIs for tasks to easily create/use a JRuby ScriptingContainer #25

Closed
rtyler opened this issue Aug 20, 2014 · 2 comments
Closed

Add APIs for tasks to easily create/use a JRuby ScriptingContainer #25

rtyler opened this issue Aug 20, 2014 · 2 comments

Comments

@rtyler
Copy link
Member

rtyler commented Aug 20, 2014

Relates to #20, #15 and future enhancements

We basically need some simple tooling to allow for building on top of an embedded JRuby scripting environment.

@ysb33r
Copy link
Contributor

ysb33r commented Sep 4, 2014

Thinking around loading jruby-complete.jar ...

In order to have this JAR available within the main Gradle runner, we have two options I believe

[1] Specify require version in buildscript

buildscript {
  dependencies {
    classpath 'org.jruby.jruby-complete:1.7.15'
  }
}

Relatively simple, but causes a conflict in UX. There is already a jruby.jrubyVersion and a `jruby.execVersion' that respectively controls the version for artifact building and executing ruby scripts. Now we are adding a 3rd way? Maybe not such a good idea

[2] Use a classloader. This is more complex to code, but is could actually utilise the jruby.jrubyVersion value and late-load the jar. However, we need to be sure that we only ever load one version of jruby-complete within the Gradle process. We also need to be sure as to when we are going to need this within the process. What if we start using ruby scripting as part of configuration? Since jruby.jrubyVersion is not fully set until project.evaluate() is called, we could end up in the nasty situation where we need to load a version of jruby only to be told later that it is the wrong version. Now option 1 suddenly looks better...

rtyler pushed a commit that referenced this issue Jun 6, 2015
@rtyler
Copy link
Member Author

rtyler commented Sep 16, 2015

We have JRubyExec now and I've not seen other needs for embedding Ruby in Gradle files so I'm going to close this

@rtyler rtyler closed this as completed Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants