Better range resolve #120
Merged
Better range resolve #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkristian
force-pushed
the
better-range-resolve
branch
from
fa593ee
to
6d1d6d5
Compare
| @@ -14,7 +14,7 @@ apply from: 'gradle/integration-tests.gradle' | |||
|
|
|||
|
|
|||
| group = 'com.github.jruby-gradle' | |||
| version = '0.1.16' | |||
| version = '0.1.17' | |||
There was a problem hiding this comment.
The version out already is 0.1.17, this should be 0.1.18 at least
gradle just picks the latest and newest version when there are conflicting versions ranges regardless whether it obeys the involved ranges or not. this patch tries obey ranges. if there is no overlap between two ranges for the same gem then it fails. the second range the same gem will be narrowed down to the intersection of the first and second range. it still can fail but now you can fix things be reordering you dependencies a bit for most cases.
mkristian
force-pushed
the
better-range-resolve
branch
from
6d1d6d5
to
661c97d
Compare
|
Looks great dude! Thanks for dading such informative comments |
|
yay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.