some (irreleant) code cleanup

jruby · Jan 29, 2013 · 6c7b686 · 6c7b686
1 parent cf9fdd8
commit 6c7b686
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 12 deletions.
diff --git a/lib/arjdbc/derby/adapter.rb b/lib/arjdbc/derby/adapter.rb
@@ -3,7 +3,7 @@
 module ::ArJdbc
   module Derby
     def self.column_selector
-      [/derby/i, lambda {|cfg,col| col.extend(::ArJdbc::Derby::Column)}]
+      [ /derby/i, lambda { |cfg, column| column.extend(::ArJdbc::Derby::Column) } ]
     end
 
     def self.monkey_rails
@@ -14,12 +14,11 @@ def self.monkey_rails
         # compare a CHAR value to a NUMBER column.
         ::ActiveRecord::Associations::ClassMethods.module_eval do
           private
-
           def select_limited_ids_list(options, join_dependency)
             connection.select_all(
-                                  construct_finder_sql_for_association_limiting(options, join_dependency),
-                                  "#{name} Load IDs For Limited Eager Loading"
-                                  ).collect { |row| connection.quote(row[primary_key], columns_hash[primary_key]) }.join(", ")
+              construct_finder_sql_for_association_limiting(options, join_dependency),
+              "#{name} Load IDs For Limited Eager Loading"
+            ).collect { |row| connection.quote(row[primary_key], columns_hash[primary_key]) }.join(", ")
           end
         end
 
@@ -66,7 +65,10 @@ def adapter_name #:nodoc:
 
     def self.arel2_visitors(config)
       require 'arel/visitors/derby'
-      {}.tap {|v| %w(derby jdbcderby).each {|a| v[a] = ::Arel::Visitors::Derby } }
+      {
+        'derby' => ::Arel::Visitors::Derby,
+        'jdbcderby' => ::Arel::Visitors::Derby,
+      }
     end
 
     include ArJdbc::MissingFunctionalityHelper

diff --git a/lib/arjdbc/jdbc/column.rb b/lib/arjdbc/jdbc/column.rb
@@ -5,16 +5,13 @@ class JdbcColumn < Column
 
       def initialize(config, name, default, *args)
         call_discovered_column_callbacks(config)
-        super(name,default_value(default),*args)
+        super(name, default_value(default), *args)
         init_column(name, default, *args)
       end
 
-      def init_column(*args)
-      end
+      def init_column(*args); end
 
-      def default_value(val)
-        val
-      end
+      def default_value(value); value; end
 
       protected