Skip to content

Commit

Permalink
deprecate (unused) insert_bind + note on IndexDefinition args
Browse files Browse the repository at this point in the history
  • Loading branch information
kares committed Apr 4, 2013
1 parent 34bb525 commit af15239
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/java/arjdbc/jdbc/RubyJdbcConnection.java
Expand Up @@ -660,6 +660,7 @@ runtime, caseConvertIdentifierForRails(metaData, columnName)
RubyString.newUnicodeString(runtime, indexName), // index_name
runtime.newBoolean( ! nonUnique ), // unique
runtime.newArray() // [] for column names, we'll add to that in just a bit
// orders, (since AR 3.2) where, type, using (AR 4.0)
};

indexes.add( indexDefinition.callMethod(context, "new", args) ); // IndexDefinition.new
Expand All @@ -679,10 +680,11 @@ runtime, caseConvertIdentifierForRails(metaData, columnName)
});
}

// NOTE: this seems to be not used ... at all, deprecate ?
// NOTE: this seems to be not used ... at all ?!
/*
* sql, values, types, name = nil, pk = nil, id_value = nil, sequence_name = nil
*/
@Deprecated
@JRubyMethod(name = "insert_bind", required = 3, rest = true)
public IRubyObject insert_bind(final ThreadContext context, final IRubyObject[] args) throws SQLException {
final Ruby runtime = context.getRuntime();
Expand All @@ -701,7 +703,7 @@ public IRubyObject call(final Connection connection) throws SQLException {
});
}

// NOTE: this seems to be not used ... at all, deprecate ?
// NOTE: this seems to be not used ... at all ?!
/*
* sql, values, types, name = nil
*/
Expand Down

0 comments on commit af15239

Please sign in to comment.