Permalink
Browse files

deprecate (unused) insert_bind + note on IndexDefinition args

  • Loading branch information...
1 parent 34bb525 commit af1523917af9f299b32c5459a94b3346de5f7046 @kares kares committed Apr 4, 2013
Showing with 4 additions and 2 deletions.
  1. +4 −2 src/java/arjdbc/jdbc/RubyJdbcConnection.java
@@ -660,6 +660,7 @@ public IRubyObject call(final Connection connection) throws SQLException {
RubyString.newUnicodeString(runtime, indexName), // index_name
runtime.newBoolean( ! nonUnique ), // unique
runtime.newArray() // [] for column names, we'll add to that in just a bit
+ // orders, (since AR 3.2) where, type, using (AR 4.0)
};
indexes.add( indexDefinition.callMethod(context, "new", args) ); // IndexDefinition.new
@@ -679,10 +680,11 @@ public IRubyObject call(final Connection connection) throws SQLException {
});
}
- // NOTE: this seems to be not used ... at all, deprecate ?
+ // NOTE: this seems to be not used ... at all ?!
/*
* sql, values, types, name = nil, pk = nil, id_value = nil, sequence_name = nil
*/
+ @Deprecated
@JRubyMethod(name = "insert_bind", required = 3, rest = true)
public IRubyObject insert_bind(final ThreadContext context, final IRubyObject[] args) throws SQLException {
final Ruby runtime = context.getRuntime();
@@ -701,7 +703,7 @@ public IRubyObject call(final Connection connection) throws SQLException {
});
}
- // NOTE: this seems to be not used ... at all, deprecate ?
+ // NOTE: this seems to be not used ... at all ?!
/*
* sql, values, types, name = nil
*/

0 comments on commit af15239

Please sign in to comment.