Fix mssql failure when inserting into tables with composite primary keys #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@enebo I can't remember which direction we merge, should I have pointed this somewhere higher? |
|
@rdubya for posterity if anyone else reads this PR. 50-stable merges to 51-stable ... So this will hit all rails 5+ trees in the merge process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed the test suite started failing for the activerecord-jdbcsqlserver-adapter gem after the latest version and tracked it down to MSSQL's driver not playing nice. I believe this change will need to be applied to all the branches. After we release the changes, I'll release a new version of the jdbcsqlserver gem that bumps the required version for this gem.