Fix broken limit_helpers #646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Falk, MS code is quite hacky and since there's been issues with merging code without checking for test regressions it will have to wait until I'm able to run tests against SQLServer and verify. You can speed this up by running the suite yourself and confirming it did not cause any additional failures, thanks! |
kares
added a commit
to kares/activerecord-jdbc-adapter
that referenced
this pull request
Sep 11, 2015
…s temporary objects
kares
added a commit
to kares/activerecord-jdbc-adapter
that referenced
this pull request
Sep 11, 2015
kares
added a commit
that referenced
this pull request
Sep 14, 2015
* 1-3-stable: (152 commits) 1.3.18 is happening :now: warn on mimer and informix adapters as unsupported on 4.2 re-built adapter jar preparing for 1.3.18 fill in change-log as PG's BC test refactoring revealed insert_returning config is failing - pend since arel visitor instances might get re-used we need to avoid the @instance variable [mssql] there are 3 hard problems in it: naming, caching and SQLServer AREL visitors ! [mssql] re-arrange visitor to only fetch PK if really needed handle regression - it's :datetime won't exists on PG :timestamp will ... [postgres] work-around BC time parsing issue (on JRuby 1.7.x) by a patch make sure Postgre's native part does type-cast on timestamp2ruby (for correctness) [mssql] fix broken ordering on an aggregate queries (test for fix #646 closing #532) tune replace limit/offset code (merged from #646) to produce less temporary objects Fix broken limit_helpers deprecate attr writers on column instance handle id updatting with partial updates disabled test on AR >= 4.0 remove FIXME note - type_cast_from_database already goes along + tune doc [mssql] extract default values such as ((-1)) returned from JDBC change typos in test names ... Conflicts: .travis.yml lib/arjdbc/firebird/adapter.rb lib/arjdbc/jdbc/adapter_java.jar lib/arjdbc/mimer.rb lib/arjdbc/mssql/adapter.rb lib/arjdbc/oracle/adapter.rb lib/arjdbc/version.rb rakelib/02-test.rake src/java/arjdbc/jdbc/RubyJdbcConnection.java src/java/arjdbc/mssql/MSSQLRubyJdbcConnection.java src/java/arjdbc/oracle/OracleRubyJdbcConnection.java src/java/arjdbc/postgresql/PostgreSQLRubyJdbcConnection.java test/db/firebird/simple_test.rb test/jndi_callbacks_test.rb test/simple.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #645 and maybe also #532.