Added minimal implementation of PGconn with unescape_bytea

[donv]

To fix #651 and #652 .

[donv]

Before:

380 tests, 608 assertions, 4 failures, 21 errors, 2 pendings, 72 omissions, 0 notifications

After:

380 tests, 639 assertions, 4 failures, 17 errors, 2 pendings, 72 omissions, 0 notifications

4 errors fixed. OK to merge?

[prathamesh-sonpatki]

👍

[kares]

Thanks Uwe, looks good however with jruby-pg around it's quite ugly to pollute their name-space ... we did moneky-patch AR previously so would you mind if I change that ?

also I'm not sure why you put up the 1.4 target ... I'd like to put it on 1-3-stable and then merge here so that it lands in next stable release (for 1.4 I would also move this code into native), thoughts?

[donv]

Hi @kares !

Thanks for looking at this. Feel free to change as you see fit 😄 and put on the 1-3-stable as well. I was unsure if 1-3-stable targeted AR 4.2.

I got an error using schema_plus without any implemented PGconn because the OID implementation for PostgreSQL is loaded then. Not sure if this is intended, but it seems ARJDBC aims to use as much standard AR as possible, and AR uses PGconn directly.

[kares]

oh, you guys merged that already - well just go for it than - I do not have time to "play" around AR 4.2 compatibility hacks just be aware when introducing another :) ... planning a 1.4 pre-release from master.

[kares]

@donv OID was completely re-invented previously, AR "promised" mixins will be shareable ...but it's not :(

[donv]

I'd like everyone to play nice together, but it seems jruby-pg and ARJDBC are exclusive, right? They should not be used together? AR+ARJDBC or AR+jruby-pg, right?

[kares]

why would they be exclusive? ... I mean for AR they might be, but pg is not made solely for AR ...

[kares]

... you can hide the PGConn under OID module (for now) ... it should work since there's no ::PGConn

[donv]

Oh. I'm learning, then :) How would you use jruby-pg with ARJDBC?

I'll move the PGconn class below the ActiveRecord::ConnectionAdapters::PostgreSQL::OID module.

[kares]

I mean for AR they might be, but pg is not made solely for AR ...

... one can access DBs in different ways (along side with AR) - which is probably uncommon but possible