Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve AM::Type::Boolean::FALSE_VALUES for Rails 5. #705

Closed
wants to merge 1 commit into from
Closed

Retrieve AM::Type::Boolean::FALSE_VALUES for Rails 5. #705

wants to merge 1 commit into from

Conversation

josemotanet
Copy link
Contributor

Relates to #704.

FALSE_VALUES isn't found in AR::ConnectionAdapters::Column anymore, but rather in AM::Type::Boolean.

EDIT: Not complete as I need to test it out with a new Rails project. I've just encountered other issues. Stand by.

@kares Help me review it? Thanks! <3

@kares
Copy link
Member

kares commented Jan 8, 2016

looking good, thanks! just try to handle backwards compatibility whenever introducing "breaking" changes.

@kares kares added the rails-5.x label Jan 8, 2016
@RUN-CMD
Copy link

RUN-CMD commented Jan 19, 2016

Is there anything we can do to help this along?

Also, the link to the Travis build is inaccessible:
https://travis-ci.org/jruby/activerecord-jdbc-adapter/builds/100861389

I would like to see the failures on Travis in order to compare against local test failures.

The old builds are still visible under @kares account on Travis:
https://travis-ci.org/kares/activerecord-jdbc-adapter

Thank you!

@kares
Copy link
Member

kares commented Jan 20, 2016

hmm, smt seriously gone wrong with travis-ci ... need to ask #jruby org admins to try fix it for us.

best is to fork the repo and maybe target 1-3-stable as master might take a while to release (although if you're willing to help out there it would be appreciated) and its not completely 💚 (1-3 branch should be).

there's also a recent attempt at #708 https://github.com/jensnockert/activerecord-jdbc-adapter/tree/ar-50 ... we really need granular one-by-one commits that are explaining changes. the problem is that betas and final sometimes mean a lot of re-work for AR-JDBC (last 4.2 sure did). not sure how much changes there will be in 5 (hopefully not as much as 4.2) but full compatibility might be a lot of work and you need to commit to it.

@kares
Copy link
Member

kares commented Mar 8, 2016

fbc5adc (with a backport from master: 783bd8a) now on 1-3-stable ... thank you for the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants