Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reversible syntax for change_column_default #754

Conversation

yahonda
Copy link
Contributor

@yahonda yahonda commented Oct 11, 2016

Refer rails/rails#20018

This pull request addresses these two errors.

$ bundle exec ruby -W -w -I"lib:test" test/cases/migration/columns_test.rb -n test_change_column_default_with_from_and_to
/home/yahonda/.rbenv/versions/jruby-9.1.5.0/lib/ruby/stdlib/tmpdir.rb:40: warning: shadowing outer local variable - dir
Using jdbcsqlite3
/home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/jdbc/adapter.rb:731: warning: `*' interpreted as argument prefix
Run options: -n test_change_column_default_with_from_and_to --seed 54298

# Running:

E

Finished in 0.181000s, 5.5249 runs/s, 0.0000 assertions/s.

  1) Error:
ActiveRecord::Migration::ColumnsTest#test_change_column_default_with_from_and_to:
TypeError: can't quote Hash
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb:177:in `_quote'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/sqlite3/quoting.rb:27:in `_quote'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb:22:in `quote'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb:110:in `quote_default_expression'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb:17:in `quote_default_expression'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb:113:in `add_column_options!'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/sqlite3/schema_creation.rb:17:in `add_column_options!'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb:34:in `visit_ColumnDefinition'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb:14:in `accept'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb:45:in `block in visit_TableDefinition'
    org/jruby/RubyArray.java:2492:in `map'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb:45:in `visit_TableDefinition'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb:14:in `accept'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb:278:in `create_table'
    /home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/util/table_copier.rb:33:in `copy_table'
    /home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/util/table_copier.rb:25:in `move_table'
    /home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/util/table_copier.rb:18:in `block in alter_table'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in `block in transaction'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/transaction.rb:189:in `within_new_transaction'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in `transaction'
    /home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/util/table_copier.rb:14:in `alter_table'
    /home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/sqlite3/adapter.rb:508:in `change_column_default'
    test/cases/migration/columns_test.rb:272:in `test_change_column_default_with_from_and_to'

1 runs, 0 assertions, 0 failures, 1 errors, 0 skips
$
$ bundle exec ruby -W -w -I"lib:test" test/cases/migration/columns_test.rb -n test_change_column_default_with_from_and_to
/home/yahonda/.rbenv/versions/jruby-9.1.5.0/lib/ruby/stdlib/tmpdir.rb:40: warning: shadowing outer local variable - dir
Using jdbcsqlite3
/home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/jdbc/adapter.rb:731: warning: `*' interpreted as argument prefix
Run options: -n test_change_column_default_with_from_and_to --seed 31369

# Running:

E

Finished in 0.150000s, 6.6667 runs/s, 0.0000 assertions/s.

  1) Error:
ActiveRecord::Migration::ColumnsTest#test_change_column_default_with_from_and_to:
TypeError: can't quote Hash
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb:177:in `_quote'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/sqlite3/quoting.rb:27:in `_quote'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb:22:in `quote'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb:110:in `quote_default_expression'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb:17:in `quote_default_expression'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb:113:in `add_column_options!'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/sqlite3/schema_creation.rb:17:in `add_column_options!'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb:34:in `visit_ColumnDefinition'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb:14:in `accept'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb:45:in `block in visit_TableDefinition'
    org/jruby/RubyArray.java:2492:in `map'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb:45:in `visit_TableDefinition'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb:14:in `accept'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb:278:in `create_table'
    /home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/util/table_copier.rb:33:in `copy_table'
    /home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/util/table_copier.rb:25:in `move_table'
    /home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/util/table_copier.rb:18:in `block in alter_table'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in `block in transaction'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/transaction.rb:189:in `within_new_transaction'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in `transaction'
    /home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/util/table_copier.rb:14:in `alter_table'
    /home/yahonda/git/activerecord-jdbc-adapter/lib/arjdbc/sqlite3/adapter.rb:508:in `change_column_default'
    test/cases/migration/columns_test.rb:272:in `test_change_column_default_with_from_and_to'

1 runs, 0 assertions, 0 failures, 1 errors, 0 skips
$

@yahonda yahonda closed this Oct 11, 2016
@yahonda yahonda deleted the rails-5_reversible_change_column_default branch November 21, 2017 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant