Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to access the Unicode version and the Unicode emoji version #29

Closed
eregon opened this issue Dec 12, 2019 · 5 comments
Closed

A way to access the Unicode version and the Unicode emoji version #29

eregon opened this issue Dec 12, 2019 · 5 comments

Comments

@eregon
Copy link
Member

eregon commented Dec 12, 2019

MRI reports both of these as RbConfig::CONFIG['UNICODE_VERSION'] and RbConfig::CONFIG['UNICODE_EMOJI_VERSION'].
Is there a way to get those values from JCodings? I could not find one.

Maybe we could expose the version from scripts/generate.rb or the last age from 549d631#diff-f7b7fcd9408309a7a3e666c1cc8c91b0 ?

@lopex
Copy link
Member

lopex commented Jan 2, 2020

yeah, so it should go to UnicodeProperties, any preference wrt the name ?

@eregon
Copy link
Member Author

eregon commented Jan 3, 2020

I would use the same as MRI, so UNICODE_VERSION and UNICODE_EMOJI_VERSION

@headius
Copy link
Member

headius commented Mar 5, 2020

Relates to jruby/jruby#5576 and would fix two specs.

@headius
Copy link
Member

headius commented Mar 29, 2020

I have hardcoded these in JRuby for now.

headius added a commit to jruby/jruby that referenced this issue May 15, 2020
@eregon
Copy link
Member Author

eregon commented May 15, 2020

Thanks!
As long as they're kept up-to-date with the version of Unicode JCodings implements this sounds a good approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants