Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ability to escape from combinatorial explosion early #36

Closed
talevy opened this issue May 18, 2018 · 6 comments
Closed

Enable ability to escape from combinatorial explosion early #36

talevy opened this issue May 18, 2018 · 6 comments
Milestone

Comments

@talevy
Copy link

talevy commented May 18, 2018

Joni's look-ahead/look-behind feature in evaluating regex matches can find themselves in large recursive loops causing things like elastic/elasticsearch#28731 to occur.

It would be nice to be able to enable Config.CEC so that combinatorial explosion heuristically checks can be applied to prevent certain matches to explode things.

The ability to interrupt the engine thread is nice, but it would be great if one did not have to spawn a timer on a separate thread just to watch the engine and prevent it from taking up too many resources.

any thoughts?

@nezda
Copy link
Contributor

nezda commented May 11, 2020

Similar to this I'd like to enable

final boolean USE_CAPTURE_HISTORY = false;

but it isn't configurable. As an interface, these aren't even fields we can change https://stackoverflow.com/a/11070886/689119 .

@headius
Copy link
Member

headius commented May 11, 2020

These seem like fine things to open up for configuration.

@headius
Copy link
Member

headius commented May 11, 2020

FWIW I am guessing these config fields were added with the intent being that they'd eventually be configurable (otherwise why bother hardcoding them to false), so this would be a natural progression for the library.

@headius
Copy link
Member

headius commented Oct 28, 2021

Anyone want to attempt a PR to add configuration items for these constants? It wouldn't be difficult since we already have some logic for configuration.

nezda added a commit to nezda/joni that referenced this issue May 22, 2023
…operties

* note: used underscores instead of periods used in the joni.debug* options
headius added a commit that referenced this issue May 23, 2023
[#36] allow changing almost everything in Config using System Properties
@headius headius added this to the 2.1.49 milestone May 23, 2023
@headius
Copy link
Member

headius commented May 23, 2023

Fixed by #67.

@headius headius closed this as completed May 23, 2023
@headius headius modified the milestones: 2.1.49, 2.2.0 May 23, 2023
@headius
Copy link
Member

headius commented May 23, 2023

Moved to 2.2.0 because we're also landing some API changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants