Remove unsound quantifier reduction rules. #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the quantifier reduction rules in oniguruma are invalid, leading to new regular expressions with different semantics. This PR removes two such reduction rules.
Here they are illustrated. If we introduce a capture group in between the two quantifiers, we prevent the quantifier reduction from triggering, leading to a different result.
I have reported the issue to MRI Ruby. This PR is a port of their PR.
https://bugs.ruby-lang.org/issues/17341
ruby/ruby#3808