Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPTIONS calls don't get passed to application in Jetty #205

Closed
retoo opened this issue May 9, 2016 · 0 comments
Closed

OPTIONS calls don't get passed to application in Jetty #205

retoo opened this issue May 9, 2016 · 0 comments

Comments

@retoo
Copy link

retoo commented May 9, 2016

This is the same problem as in #153, but this time with Jetty instead of Tomcat. Jetty's implementation of DefaultServlet#doOptions sets both 'Allow' and 'Date' and therefore slips through the fix in #153.

  1. install rack-cors gem
  2. configure policy, ensure it runs with webrick
  3. deploy app in jetty-runner / war (using jruby-rack)
  4. Only Allow and Date are set, rack-cors will not be called
retoo added a commit to retoo/jruby-rack that referenced this issue May 9, 2016
@retoo
When handling OPTION calls ignore both 'Date' and 'Allow' headers to …
25037c0 
…decide if call has been handeled

If not, no OPTION calls will be passed down to the rack app due to the fact
that some implementations of DefaultServlet (i.e. Jetty and Tomcat) already sets
these fields. Fixes jruby#205
@retoo retoo mentioned this issue May 9, 2016
Closed
kares pushed a commit that referenced this issue Aug 2, 2017
@retoo @kares
When handling OPTION calls ignore both 'Date' and 'Allow' headers
91d7d30 
to decide if call has been handeled

If not, no OPTION calls will be passed down to the rack app due to the fact
that some implementations of DefaultServlet (i.e. Jetty) also sets 'Date'

Fixes #205
@kares kares closed this as completed Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@retoo @kares