Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 1.1 into master #253

Open
wants to merge 75 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
954e795
appraise latest rails versions
kares Apr 27, 2015
342d4f8
let us see how we're doing with the travis-ci test matrix
kares Apr 27, 2015
564f5f6
make sure i18n < 0.7 for Rails 3.x still test run with 1.8 mode
kares Apr 28, 2015
0c67f6c
more travis-ci magic to get specs rolling again
kares Apr 28, 2015
ce31f75
just to be sure about travis-ci ... update rake everywhere to 10.4.2
kares Apr 28, 2015
22bb8b2
allow for more `JRuby::Rack::ErrorApp` customizations + retrieve caus…
kares Apr 28, 2015
e369146
tune ErrorApp + ShowStatus (use-d by default) to respect set 'rack.sh…
kares Apr 28, 2015
e5ca043
avoid failures with rack < 1.5 since it's Rack::Request#scheme would …
kares Apr 29, 2015
8da7440
servlet attributes with null/false values should not end up with an '…
kares Apr 29, 2015
caf7a38
[travis-ci] jruby -G does not work with 1.6.8 ... kind of use ~ bundl…
kares Apr 29, 2015
1a01517
[travis-ci] back to `rake spec` for now (only due 1.6.8)
kares Apr 30, 2015
29f46b4
update (bundled) rack to 1.5.5
kares Jun 28, 2015
ee6f164
use spec.base_dir (instead of installation_path)
kares Jun 28, 2015
2693ff3
work-around respond_to_missing? bug in JRuby 1.7.20
kares Jun 28, 2015
d0323ed
bundle update jruby-openssl
kares Jun 28, 2015
1aae207
update appraised rails versions
kares Jun 30, 2015
dcecc35
update jruby-maven-plugins' version
kares Jun 30, 2015
7eda40a
update bundler used during mvn build
kares Jun 30, 2015
ff85d14
prepare for 1.1.19
kares Jul 1, 2015
3f93d44
release actually happened on 1.7
kares Jul 1, 2015
fa0f042
update for next development SNAPSHOT
kares Jul 1, 2015
8da098e
[travis-ci] re-invent - simplify setup + test on 9K
kares Jan 21, 2016
9468cb8
seems its easy to avoid the confusing spec failure on 1.6.8 (due BUG)
kares Jan 21, 2016
9851506
[travis-ci] expect rails 4.2 to pass fine
kares Jan 21, 2016
f547986
update appraisals to their latest
kares Jan 21, 2016
864d68e
servlet env should behave on `fetch` and `[]` like a Hash (nil value …
kares Jan 21, 2016
859a90c
bundle update jruby-openssl
kares Jan 21, 2016
9391d2a
(c) 2016!
kares Jan 21, 2016
33fd974
adjust jruby home dir fallback (for default $LOAD_PATH) correctly on …
kares Jan 21, 2016
fb7a4c3
Add a `ActionController::Base` method to return the `servlet_response`
ketan Dec 25, 2015
4071a01
stub-ed specs have not been running - change that and re-invent rails…
kares Jan 21, 2016
a100eac
adjust stubbing setup - do not unshift LOAD_PATH in spec_helper
kares Jan 21, 2016
91245b8
improvise more rails boot isolation in "stub" spec - now that more of…
kares Jan 21, 2016
4281a98
for better booter detection - export public path after working direct…
kares Jan 21, 2016
d81684b
allow to boot when RAILS_ROOT/public directory does not exist (closes…
kares Jan 21, 2016
2d8a988
fix broken controller.servlet_response spec from #201
kares Jan 21, 2016
4771f92
pre-maturely avoid Ruby frozen string literals coming at us ... ''.du…
kares Jan 22, 2016
3605090
fill in release notes for 1.1.20
kares Jan 22, 2016
5c31797
use recent jruby-openssl that works better with all jrubies
kares Jan 22, 2016
65dc2fc
[travis-ci] 1.7.16 has loading issues with jossl thus try 1.7.4 instead
kares Jan 22, 2016
0c1f3c7
[travis-ci] let those jossl issues fail until there's time to figure …
kares Jan 22, 2016
0d40a1b
re-invent missing Rack::Utils.bytesize (2.0 will work) + prefix ::Rac…
kares Jan 22, 2016
23a0858
setup testing against rails 5.0 beta1 (using rack 2.0.alpha)
kares Jan 22, 2016
77b4c34
prepare for 1.1.20
kares Jan 22, 2016
620ac03
update for next dev SNAPSHOT
kares Jan 22, 2016
f2d442e
one line is enough ... `lines -= 5`
kares Jan 22, 2016
7951186
[travis-ci] update JRuby testing targets
kares Aug 1, 2017
f2295ce
[travis-ci] try to not mess with RG installation on 9K + adjust for s…
kares Aug 1, 2017
3120eeb
[spec] adjust booter LOAD_PATH expectation to pass on JRuby 9.1
kares Aug 2, 2017
abe79d0
[spec] seems LoadError is not being rescued when using base Gemfile
kares Aug 2, 2017
628bd96
[travis-ci] running with RG 2.6 should get the (problematic) specs green
kares Aug 2, 2017
1e81098
[bundle] upgrade to recent jruby-openssl 0.9
kares Aug 2, 2017
0afcafd
update appraised gemfiles - so that we have a working jossl 4all
kares Aug 2, 2017
91efe06
[travis-ci] adjust accepted failures - 1.7.4 no longer failing due jossl
kares Aug 2, 2017
91d7d30
When handling OPTION calls ignore both 'Date' and 'Allow' headers
retoo Aug 2, 2017
0e0ba6a
fix wrong condition for OPTION to ignore both 'Date' and 'Allow' headers
kares Aug 3, 2017
49a3673
can only safely stream natively on ActionDispatch <= 3.2
kares Aug 3, 2017
15d17ed
Add Rack::Handler::Servlet::DefaultEnv#get_header (#212)
HarlemSquirrel Aug 17, 2017
714fee2
update (bundled) rack to latest in 1.x line ... 1.6.8
kares Sep 17, 2017
2774bfc
prepare for 1.1.21
kares Sep 17, 2017
4ed7a4e
Add error message to log when runtime error is handled (fixes #213)
daneshd Jan 9, 2018
5854db8
degrade level (back) to INFO and log trace when commited
kares Sep 6, 2018
b2c7cab
[fix] Don't let getSession cause an infinite loop if it throws Illega…
smellsblue Dec 3, 2020
a9dac39
avoid Fixnum warning - assume recent JRuby
kares Aug 16, 2022
ba0abaf
avoid NativeException - not used on recent JRuby
kares Aug 16, 2022
ec34317
[release] late next dev snapshot update
kares Aug 16, 2022
0a3eb45
update (bundled) rack to 1.6.13
kares Aug 16, 2022
a24d58a
[build] update bundler + hook-up mavengem
kares Aug 16, 2022
c5e2b1b
compile using Java 6 source compat
kares Aug 16, 2022
bae8b2c
[release] prepare for 1.1.22
kares Aug 16, 2022
63cf7d0
[build] update maven deploy plugin
kares Aug 16, 2022
754e7af
[build] try release with nexus plugin
kares Aug 16, 2022
c993abc
[build] disable javadoc lint on Java 8
kares Aug 16, 2022
cbee8b5
Merge branch '1.1-stable' of github.com:jruby/jruby-rack into 1.1-stable
kares Aug 16, 2022
160e933
Merge remote-tracking branch 'origin/1.1-stable' into merge-1.1-stable
headius Jun 4, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
158 changes: 152 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,18 @@ branches:
- /.*stable$/
- /^test-.*$/
rvm:
<<<<<<< HEAD
# NOTE: do not use jruby-19mode otherwise some specs might fail
# @see ruby/rack/application_spec.rb for an explanation on this
#- jruby-18mode
#- jruby-19mode
- jruby-1.7.16
- jruby-head
=======
- jruby-1.6.8
- jruby-1.7.26
#- jruby-9.1.8.0 see include matrix
>>>>>>> origin/1.1-stable
jdk:
- openjdk6
- oraclejdk7
Expand All @@ -27,20 +33,26 @@ gemfile:
- gemfiles/rails32.gemfile
- gemfiles/rails40.gemfile
- gemfiles/rails41.gemfile
env:
- JRUBY_OPTS="--1.8 $JRUBY_OPTS"
- JRUBY_OPTS="$JRUBY_OPTS" JAVA_OPTS="-Djruby.version=$JRUBY_VERSION" # for mvn's jruby plugins
- gemfiles/rails42.gemfile
#env:
##- JRUBY_OPTS="--1.8 $JRUBY_OPTS"
#- JRUBY_OPTS="$JRUBY_OPTS" JAVA_OPTS="-Djruby.version=$JRUBY_VERSION" # for mvn's jruby plugins
before_script:
<<<<<<< HEAD
- export JRUBY_OPTS="--server -Xcext.enabled=false -Xcompile.invokedynamic=false -J-XX:MaxPermSize=128m"
- export JRUBY_VERSION="1.7.13"
- jruby -S gem env || true
=======
- export JRUBY_OPTS="-Xcompile.invokedynamic=false -J-XX:MaxPermSize=96M"
>>>>>>> origin/1.1-stable
before_install:
# NOTE: RubyGems 2.4.x fails us at application_spec's gem_install_rack_unless_installed !
- (jruby --1.9 -S gem update --system 2.2.3) || true
- ((jruby -v | grep -v 9.[0-9].[0-9].[0-9]) && jruby --1.9 -S gem update --system 2.6.12) || true
- ((jruby -v | grep 1.8.7) && jruby --1.9 -S gem update --system 2.1.11) || true
- ((echo $BUNDLE_GEMFILE | grep rails23) && jruby --1.9 -S gem update --system 1.8.29) || true
matrix:
allow_failures:
<<<<<<< HEAD
#- gemfile: gemfiles/rails41.gemfile
exclude:
## avoid jruby-head with JDK6 :
Expand Down Expand Up @@ -125,15 +137,138 @@ matrix:
- rvm: jruby-1.7.16
gemfile: gemfiles/rails41.gemfile
env: JRUBY_OPTS="--1.8 $JRUBY_OPTS"
=======
- rvm: jruby-1.6.8
- gemfile: Gemfile
- gemfile: gemfiles/railsNG.gemfile
include:
# jruby-9.1.8.0
- rvm: jruby-9.1.8.0
gemfile: gemfiles/rails32.gemfile
jdk: oraclejdk7
- rvm: jruby-9.1.8.0
gemfile: gemfiles/rails32.gemfile
jdk: oraclejdk8
- rvm: jruby-9.1.8.0
gemfile: gemfiles/rails40.gemfile
jdk: oraclejdk7
- rvm: jruby-9.1.8.0
gemfile: gemfiles/rails40.gemfile
jdk: oraclejdk8
- rvm: jruby-9.1.8.0
gemfile: gemfiles/rails41.gemfile
jdk: oraclejdk7
- rvm: jruby-9.1.8.0
gemfile: gemfiles/rails41.gemfile
jdk: oraclejdk8
- rvm: jruby-9.1.8.0
gemfile: gemfiles/rails42.gemfile
jdk: oraclejdk7
- rvm: jruby-9.1.8.0
gemfile: gemfiles/rails42.gemfile
jdk: oraclejdk8
# rails NG
- rvm: jruby-9.1.8.0
gemfile: gemfiles/railsNG.gemfile
jdk: oraclejdk7
- rvm: jruby-9.1.8.0
gemfile: gemfiles/railsNG.gemfile
jdk: oraclejdk8
## rails 2.3 --1.8
- rvm: jruby-1.7.4
gemfile: gemfiles/rails23.gemfile
env: JRUBY_OPTS="--1.8 $JRUBY_OPTS"
jdk: oraclejdk7
- rvm: jruby-1.7.4
gemfile: gemfiles/rails23.gemfile
env: JRUBY_OPTS="--1.8 $JRUBY_OPTS"
jdk: oraclejdk8
## rails 3.1 --1.8
- rvm: jruby-1.7.4
gemfile: gemfiles/rails31.gemfile
env: JRUBY_OPTS="--1.8 $JRUBY_OPTS"
jdk: openjdk6
- rvm: jruby-1.7.4
gemfile: gemfiles/rails31.gemfile
env: JRUBY_OPTS="--1.8 $JRUBY_OPTS"
jdk: oraclejdk7
- rvm: jruby-1.7.26
gemfile: gemfiles/rails32.gemfile
env: JRUBY_OPTS="--2.0 $JRUBY_OPTS"
jdk: oraclejdk8
exclude:
# ## avoid jruby-9K with JDK6 :
# - rvm: jruby-9.1.8.0
# gemfile: Gemfile
# jdk: openjdk6
# - rvm: jruby-9.1.8.0
# gemfile: gemfiles/rails23.gemfile
# jdk: openjdk6
# - rvm: jruby-9.1.8.0
# gemfile: gemfiles/rails30.gemfile
# jdk: openjdk6
# - rvm: jruby-9.1.8.0
# gemfile: gemfiles/rails31.gemfile
# jdk: openjdk6
# - rvm: jruby-9.1.8.0
# gemfile: gemfiles/rails32.gemfile
# jdk: openjdk6
# - rvm: jruby-9.1.8.0
# gemfile: gemfiles/rails40.gemfile
# jdk: openjdk6
# - rvm: jruby-9.1.8.0
# gemfile: gemfiles/rails41.gemfile
# jdk: openjdk6
# - rvm: jruby-9.1.8.0
# gemfile: gemfiles/rails42.gemfile
# jdk: openjdk6
## avoid jruby-1.6.8 with JDK8 :
- rvm: jruby-1.6.8
gemfile: Gemfile
jdk: oraclejdk8
- rvm: jruby-1.6.8
gemfile: gemfiles/rails23.gemfile
jdk: oraclejdk8
- rvm: jruby-1.6.8
gemfile: gemfiles/rails30.gemfile
jdk: oraclejdk8
- rvm: jruby-1.6.8
gemfile: gemfiles/rails31.gemfile
jdk: oraclejdk8
- rvm: jruby-1.6.8
gemfile: gemfiles/rails32.gemfile
jdk: oraclejdk8
- rvm: jruby-1.6.8
gemfile: gemfiles/rails40.gemfile
jdk: oraclejdk8
- rvm: jruby-1.6.8
gemfile: gemfiles/rails41.gemfile
jdk: oraclejdk8
- rvm: jruby-1.6.8
gemfile: gemfiles/rails42.gemfile
jdk: oraclejdk8
## rails 4.0 won't run on JRuby 1.6
- rvm: jruby-1.6.8
gemfile: gemfiles/rails40.gemfile
jdk: openjdk6
- rvm: jruby-1.6.8
gemfile: gemfiles/rails40.gemfile
jdk: oraclejdk7
- rvm: jruby-1.6.8
gemfile: gemfiles/rails40.gemfile
jdk: oraclejdk8
## rails 4.1 won't run on JRuby 1.6
- rvm: jruby-1.6.8
gemfile: gemfiles/rails41.gemfile
>>>>>>> origin/1.1-stable
jdk: openjdk6
- rvm: jruby-1.7.16
gemfile: gemfiles/rails41.gemfile
env: JRUBY_OPTS="--1.8 $JRUBY_OPTS"
jdk: oraclejdk7
- rvm: jruby-1.7.16
gemfile: gemfiles/rails41.gemfile
env: JRUBY_OPTS="--1.8 $JRUBY_OPTS"
jdk: oraclejdk8
<<<<<<< HEAD
## rails 4.0 does not run on --1.8 (jruby-head)
#- rvm: jruby-head
# gemfile: gemfiles/rails40.gemfile
Expand Down Expand Up @@ -296,4 +431,15 @@ matrix:
- rvm: jruby-head
gemfile: gemfiles/rails31.gemfile
env: JRUBY_OPTS="$JRUBY_OPTS" JAVA_OPTS="-Djruby.version=$JRUBY_VERSION"
=======
## rails 4.2 won't run on JRuby 1.6
- rvm: jruby-1.6.8
gemfile: gemfiles/rails42.gemfile
jdk: openjdk6
- rvm: jruby-1.6.8
gemfile: gemfiles/rails42.gemfile
jdk: oraclejdk7
- rvm: jruby-1.6.8
gemfile: gemfiles/rails42.gemfile
>>>>>>> origin/1.1-stable
jdk: oraclejdk8
15 changes: 13 additions & 2 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ appraise "rails30" do
end

appraise "rails31" do
gem "i18n", "< 0.7"
gem "rails", "~> 3.1.12"
end

appraise "rails32" do
gem "i18n", "< 0.7"
gem "rails", "~> 3.2.21"
end

Expand All @@ -19,11 +21,20 @@ appraise "rails40" do
end

appraise "rails41" do
gem "rails", "~> 4.1.10"
gem "rails", "~> 4.1.16"
end

appraise "rails42" do
gem "rails", "~> 4.2.1"
gem "mime-types", "< 3", :require => false
gem "rails", "~> 4.2.9"
end

appraise "rails50" do
gem "rails", "~> 5.0.5"
end

appraise "rails51" do
gem "rails", "~> 5.1.2"
end

appraise "railsNG" do
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ GEM
rspec-support (3.13.1)

PLATFORMS
universal-java-1.8
universal-java-22

DEPENDENCIES
appraisal (< 1.0)
Expand Down
34 changes: 34 additions & 0 deletions History.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,37 @@
## 1.1.22

- compile using Java 6 source compat
- update (bundled) rack to 1.6.13
- avoid NativeException - not used on recent JRuby
- avoid Fixnum warning - assume recent JRuby
- Add error message to log when runtime error is handled (#213)

## 1.1.21 (17/09/17)

- update (bundled) rack to 1.6.8
- add Rack::Handler::Servlet::DefaultEnv#get_header (#212)
missing methods to handle ActionController::Base#reset_session
- can only safely stream natively on ActionDispatch <= 3.2 (#210)
(broken Rails streaming for Rails 4.x)
- when handling OPTION calls ignore both 'Date' and 'Allow' headers (#205)

## 1.1.20 (22/01/16)

- pre-maturely avoid Ruby frozen string literals coming at us ... ''.dup meh!
- allow to boot when RAILS_ROOT/public directory does not exist (closes #197)
- for better booter detection - export public path after working dir was changed
- `ActionController::Base` provides a method `servlet_response` to return the
`java.servlet_response` rack env (#201)
- adjust jruby home dir fallback (for default $LOAD_PATH) correctly on 9K and --2.0
- servlet env should behave on `fetch` and `[]` like a Hash (nil value can be set)

## 1.1.19 (01/07/15)

- update (bundled) rack to 1.5.5
- servlet attrs with null/false values should not end up with an '' env value (#195)
- tune ErrorApp + ShowStatus to respect set 'rack.showstatus.detail' (#194)
- allow for more `JRuby::Rack::ErrorApp` customizations + retrieve cause when needed

## 1.1.18 (13/01/15)

- back-port Rack::ShowStatus to be used with out ErrorApp (contains XSS fix #190)
Expand Down
2 changes: 1 addition & 1 deletion LICENSE.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#--
# The MIT License
#
# Copyright (c) 2012-2014 Karol Bucek, LTD
# Copyright (c) 2012-2016 Karol Bucek, LTD.
# Copyright (c) 2010-2012 Engine Yard, Inc.
# Copyright (c) 2007-2009 Sun Microsystems, Inc.
#
Expand Down
15 changes: 10 additions & 5 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,16 @@ end
desc "Unpack the rack gem"
task :unpack_gem => "target" do |t|
target = File.expand_path(t.prerequisites.first)
spec = Gem.loaded_specs["rack"]
if spec.respond_to?(:cache_file)
gem_file = spec.cache_file
else
gem_file = File.join(spec.installation_path, 'cache', spec.file_name)
spec = Gem.loaded_specs['rack']
# JRuby <= 1.7.20 does not handle respond_to? with method_missing right
# ... issue with Bundler::StubSpecification wrapping (in bundler 1.10.x)
unless ( gem_file = spec.cache_file rescue nil )
#if defined?(::Bundler) && ::Bundler.const_defined?(:StubSpecification) # since Bundler 1.10.1
# spec = spec.to_spec if spec.is_a?(::Bundler::StubSpecification)
#else
# spec = spec.to_spec if spec.respond_to?(:to_spec)
#end
gem_file = File.join(spec.base_dir, 'cache', spec.file_name)
end
unless uptodate?("#{target}/vendor/rack.rb", [__FILE__, gem_file])
mkdir_p "target/vendor"
Expand Down
3 changes: 2 additions & 1 deletion gemfiles/rails23.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

source "https://rubygems.org"

gem "rake", "~> 10.3.1", :group=>:test, :require=>nil
gem "rake", "~> 10.4.2", :group=>:test, :require=>nil
gem "rspec", "~> 2.14.1", :group=>:test
gem "jruby-openssl", "~> 0.9.20", :group=>:test
gem "rails", "~> 2.3.18"

9 changes: 7 additions & 2 deletions gemfiles/rails23.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ GEM
activesupport (= 2.3.18)
activesupport (2.3.18)
diff-lcs (1.2.5)
jruby-openssl (0.9.21-java)
rack (1.1.6)
rails (2.3.18)
actionmailer (= 2.3.18)
Expand All @@ -20,7 +21,7 @@ GEM
activeresource (= 2.3.18)
activesupport (= 2.3.18)
rake (>= 0.8.3)
rake (10.3.2)
rake (10.4.2)
rspec (2.14.1)
rspec-core (~> 2.14.0)
rspec-expectations (~> 2.14.0)
Expand All @@ -34,6 +35,10 @@ PLATFORMS
java

DEPENDENCIES
jruby-openssl (~> 0.9.20)
rails (~> 2.3.18)
rake (~> 10.3.1)
rake (~> 10.4.2)
rspec (~> 2.14.1)

BUNDLED WITH
1.14.6
3 changes: 2 additions & 1 deletion gemfiles/rails30.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

source "https://rubygems.org"

gem "rake", "~> 10.3.1", :group=>:test, :require=>nil
gem "rake", "~> 10.4.2", :group=>:test, :require=>nil
gem "rspec", "~> 2.14.1", :group=>:test
gem "jruby-openssl", "~> 0.9.20", :group=>:test
gem "rails", "~> 3.0.20"

9 changes: 7 additions & 2 deletions gemfiles/rails30.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ GEM
erubis (2.6.6)
abstract (>= 1.0.0)
i18n (0.5.4)
jruby-openssl (0.9.21-java)
json (1.8.1-java)
mail (2.2.20)
activesupport (>= 2.3.6)
Expand Down Expand Up @@ -61,7 +62,7 @@ GEM
rake (>= 0.8.7)
rdoc (~> 3.4)
thor (~> 0.14.4)
rake (10.3.2)
rake (10.4.2)
rdoc (3.12.2)
json (~> 1.4)
rspec (2.14.1)
Expand All @@ -82,6 +83,10 @@ PLATFORMS
java

DEPENDENCIES
jruby-openssl (~> 0.9.20)
rails (~> 3.0.20)
rake (~> 10.3.1)
rake (~> 10.4.2)
rspec (~> 2.14.1)

BUNDLED WITH
1.14.6
Loading
Loading