Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows you to use jruby-rack in embedded environments #53

Closed
wants to merge 13 commits into from
Closed

Allows you to use jruby-rack in embedded environments #53

wants to merge 13 commits into from

Commits on Aug 6, 2011

  1. First stab at removing the dependency on a full servlet container env… 

    …ironment to make jruby-rack more amenable to running in embedded servlet situations
    @nicobrevin
    nicobrevin committed Aug 6, 2011
    Configuration menu
    Copy the full SHA
    1b5827b View commit details
    Browse the repository at this point in the history

  2. More open heart surgery to support embedding: 

     - Create an abstract rack filter which is responsible for calling the dispatcher and converting the req & resp into a rack env.
 - Implementations of rack filter for embedded and servlet environments
 - Include a getServerInfo method on the rack context for CGI's SERVER_INFORMATION.
 - Remove unnecessary jetty example (in a different gem - WIP)
    @nicobrevin
    nicobrevin committed Aug 6, 2011
    Configuration menu
    Copy the full SHA
    695be8e View commit details
    Browse the repository at this point in the history

  3. Minor renaming

    @nicobrevin
    nicobrevin committed Aug 6, 2011
    Configuration menu
    Copy the full SHA
    873c6aa View commit details
    Browse the repository at this point in the history

  4. Create an interface for the ServletRackContext for easier mocking

    @nicobrevin
    nicobrevin committed Aug 6, 2011
    Configuration menu
    Copy the full SHA
    41c398c View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2011

  1. Get the embedded dispatcher to keep up with abstract dispatcher, make… 

    … sure we don't refer to the default servlet rack context everywhere (use the interface)
    @nicobrevin
    nicobrevin committed Aug 7, 2011
    Configuration menu
    Copy the full SHA
    f048cd0 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2011

  1. undo a bunch of changes to the spec_helper now I have a better idea o… 

    …f what I'm doing
    @nicobrevin
    nicobrevin committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    acdd9c5 View commit details
    Browse the repository at this point in the history

  2. Make sure configure is called in testing and servlet environments, pl… 

    …us make sure it sets the servlet_rack_context
    @nicobrevin
    nicobrevin committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    e237928 View commit details
    Browse the repository at this point in the history

  3. Make sure the DYNAMIC_REQS_ONLY attribute is set

    @nicobrevin
    nicobrevin committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    a9e051e View commit details
    Browse the repository at this point in the history

  4. fix up the filter spec test after the last couple of commits

    @nicobrevin
    nicobrevin committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    71bdc81 View commit details
    Browse the repository at this point in the history

  5. Loosen the expectation around getting the rack factory from the context

    @nicobrevin
    nicobrevin committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    fe05df3 View commit details
    Browse the repository at this point in the history

  6. All tests are now passing again - Use the implementation, not the int… 

    …erface (duh)
    @nicobrevin
    nicobrevin committed Aug 13, 2011
    Configuration menu
    Copy the full SHA
    081fdfd View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2011

  1. Slight tweaks to embedded stuff, plus some basic specs

    @nicobrevin
    nicobrevin committed Aug 14, 2011
    Configuration menu
    Copy the full SHA
    2989679 View commit details
    Browse the repository at this point in the history

  2. rename doDispatch to isDoDispatch (still a bit crappily named) and a … 

    …comment to describe why it is there in the first place
    @nicobrevin
    nicobrevin committed Aug 14, 2011
    Configuration menu
    Copy the full SHA
    810ee46 View commit details
    Browse the repository at this point in the history