JSON format profile printer (additions) #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for writing profile reports to files, notably support for writing profiles from multiple threads to the same JSON or HTML file without syntax errors. There's a new abstraction that handles profile printing: ProfileOutput. Together with new methods on ProfilePrinter, printHeader, printFooter and a new parameter to printProfile (first), it can orchestrate the the profile printers so that they print the right things at the right time.
|
Theo, we will merge this right after final for 1.7.1. rc2 (which very very very likely will be 1.7.0) will be out on Monday and although this all looks solid to me is just a tad too close to this release. |
|
Thanks! Getting it into 1.7.0 would have been awesome, but I completely understand that that is not possible, no problem at all. I'm just happy that you like it. |
headius
added a commit
that referenced
this pull request
Oct 27, 2012
JSON format profile printer (additions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some additions to pull request #270, as per the discussion there.
I've added a layer of indirection between
Ruby#printProfileDataand the profile printers to make it possible to write a profile to a file. I also addedProfilePrinter#printHeaderand#printFooterto make it possible to write all thread profiles into the same file when the format is HTML or JSON, without the output being all weird. I've also updated all profile printers to support this.All changes should be backwards compatible, and I've marked the old version of
Ruby#printProfileDatathat took aPrintStreamas deprecated.I've added an optional argument to
--profile.xxxthat is the file to write to. Please check that part extra carefully so that I haven't done anything stupid. There wasn't any other argument that took optional parameters on the form--xyz optarg, only arguments like-Ioptargor that always expected a value. The way I did it was by checking if there is one more argument, and making sure that argument doesn't start with a dash. It will fail in this case:ruby --profile.json hello_world.rb, becausehello_world.rbwill be interpreted as the argument to--profile.json, not the script to run. I don't know if this is acceptable. Maybe it would be better to do it like--profile.json=output.json, but that's not how the other arguments that take values work (e.g.--compat RUBY_18).I'm not entirely satisfied with the way profiles are printed, and I'd like to do some more changes to structure it differently, but I think that another pull request that can aim for a later release.