Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RubyGems #4205

Closed
headius opened this issue Oct 5, 2016 · 8 comments
Closed

Update RubyGems #4205

headius opened this issue Oct 5, 2016 · 8 comments

Comments

@headius
Copy link
Member

@headius headius commented Oct 5, 2016

In #4198, which fixes #4019, we manually patched our in-repo copy of RubyGems. We'll need to move to an unpatched release once rubygems/rubygems#1685 is released.

@headius headius added this to the JRuby 9.1.6.0 milestone Oct 5, 2016
@headius headius closed this in 9e8e14b Nov 8, 2016
@etehtsea
Copy link
Contributor

@etehtsea etehtsea commented Nov 8, 2016

2.6.8 version still don't have fix for the #4019.

@etehtsea
Copy link
Contributor

@etehtsea etehtsea commented Nov 8, 2016

@olleolleolle as far as I remember, these two are unrelated.

@enebo
Copy link
Member

@enebo enebo commented Nov 8, 2016

@etehtsea @headius do we need to manually merge something then. 9.1.6.0 is coming out today/tomorrow so if we need something patched in 2.6.8 we should get it done pronto :)

@etehtsea
Copy link
Contributor

@etehtsea etehtsea commented Nov 8, 2016

@headius
Copy link
Member Author

@headius headius commented Nov 8, 2016

@etehtsea I'm confused then. rubygems/rubygems#1685 was merged August 17, 2.6.8 was released since then,, and I see rubygems/rubygems@d98f036 on master. But the version in 2.6.8 does not appear to have your change. I'm rather confused. Can you clarify why this fix is not in the release, @segiddins?

FWIW, this is largely a cosmetic fix, so if we have to apply a manual patch to get it perhaps we just don't bother for now.

@headius headius reopened this Nov 8, 2016
@segiddins
Copy link

@segiddins segiddins commented Nov 8, 2016

Because we only backport critical big fixes in patch releases. Default is commits must wait until a new minor.

@enebo enebo modified the milestones: JRuby 9.1.7.0, JRuby 9.1.6.0 Nov 9, 2016
@enebo enebo changed the title Update RubyGems for 9.1.6.0 Update RubyGems Dec 9, 2016
@enebo enebo modified the milestones: JRuby 9.2.0.0, JRuby 9.1.7.0 Dec 9, 2016
@headius
Copy link
Member Author

@headius headius commented May 15, 2018

RubyGems is current for 9.2.

@headius headius closed this May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants