Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align zlib behavior with CRuby #6613

Open
headius opened this issue Mar 11, 2021 · 1 comment
Open

Align zlib behavior with CRuby #6613

headius opened this issue Mar 11, 2021 · 1 comment

Comments

@headius
Copy link
Member

headius commented Mar 11, 2021

Our zlib library was very roughly ported from CRuby many years ago, as described in #4835 (comment). Unfortunately this logic has not kept up with changes and improvements in CRuby, leading to issues like #6606.

We should try to align our logic with CRuby and get all available tests passing, to avoid future incompatibility reports.

The original folks that worked on this may be interested in helping: @nahi @ymnk.

@headius headius added this to the JRuby 9.3.0.0 milestone Mar 11, 2021
@headius headius modified the milestones: JRuby 9.3.0.0, JRuby 9.4.0.0 May 19, 2021
@headius headius modified the milestones: JRuby 9.4.0.0, JRuby 9.4.1.0 Nov 16, 2022
@headius headius modified the milestones: JRuby 9.4.1.0, JRuby 9.4.2.0 Feb 6, 2023
@headius headius modified the milestones: JRuby 9.4.2.0, JRuby 9.4.3.0 Mar 1, 2023
@headius headius modified the milestones: JRuby 9.4.3.0, JRuby 9.4.4.0 Jun 6, 2023
@headius
Copy link
Member Author

headius commented Oct 17, 2023

This has not happened, but there's a big pile of zlib-related issues in the tracker that an update would fix (if they are not fixed already:

And possibly others that are peripherally caused by zlib incompatibilities.

We recently forked jzlib to fix #1422 (recently uncovered by the rack team) so it should be possible to fix these other cases now.

Bumping to 9.4.5.0 but I'll probably be the one looking into it.

@headius headius modified the milestones: JRuby 9.4.4.0, JRuby 9.4.5.0 Oct 17, 2023
@headius headius modified the milestones: JRuby 9.4.5.0, JRuby 9.4.6.0 Oct 31, 2023
@headius headius modified the milestones: JRuby 9.4.6.0, JRuby 9.5.0.0 Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant