Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsString indy logic does not handle refinements #7654

Open
headius opened this issue Feb 12, 2023 · 0 comments
Open

AsString indy logic does not handle refinements #7654

headius opened this issue Feb 12, 2023 · 0 comments

Comments

@headius
Copy link
Member

headius commented Feb 12, 2023

The logic for AsString, in AsStringInvokeSite, only supports non-refined invocation of the to_s method. When refinements are active, it falls back on normal invocation.

However, we also modified the IRBuilder such that it only uses AsString when refinements are active, since otherwise we can use faster logic for coercing dynamic string elements to Strings.

The result of this is that the indy AsString site is not currently being used. I discovered this while attempting to increase the code coverage of indy JIT.

Either this class should be deleted, or it should be improved to support refined invocation. No other indy logic currently supports fast refined invocation, so this is part of a larger project to add that capability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant