Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for vthread fibers #7907

Merged
merged 2 commits into from Aug 28, 2023
Merged

Improvements for vthread fibers #7907

merged 2 commits into from Aug 28, 2023

Conversation

headius
Copy link
Member

@headius headius commented Aug 28, 2023

  • Use method handles to launch
  • Guard behind an option so they can be disabled

@headius
Use method handles for extreme fastness
04fbe80 
Static reference to the bound handle should be inlinable into the
fiber thread launcher.
@headius
Allow disabling the use of vthread fibers
3f4de82 
In case there's an issue with vthread fibers that we have not yet
seen, this allows disabling them and going back to normal native
thread fibers.
@headius headius added this to the JRuby 9.3.11.0 milestone Aug 28, 2023
@headius
Copy link
Member Author

headius commented Aug 28, 2023

I'll do the Java 21 CI updates in a separate PR.

@headius headius marked this pull request as ready for review August 28, 2023 18:40
@headius headius merged commit 755579a into jruby:jruby-9.3 Aug 28, 2023
0 of 54 checks passed
@headius headius deleted the better_vthread_fiber branch August 28, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.3.11.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@headius